Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever III <chuck.lever@oracle.com>
To: Trond Myklebust <trondmy@hammerspace.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Cc: "anna@kernel.org" <anna@kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] NFSD: prevent integer overflow on 32 bit systems
Date: Tue, 15 Mar 2022 16:39:58 +0000	[thread overview]
Message-ID: <5AC86875-3CBC-4DA7-BAB2-46DA35324842@oracle.com> (raw)
In-Reply-To: <6229c1c4ab4b82d59503b8c5cd4d909f0e165e2e.camel@hammerspace.com>



> On Mar 15, 2022, at 12:30 PM, Trond Myklebust <trondmy@hammerspace.com> wrote:
> 
> On Tue, 2022-03-15 at 16:22 +0000, Chuck Lever III wrote:
>> 
>> 
>>> On Mar 15, 2022, at 11:34 AM, Dan Carpenter
>>> <dan.carpenter@oracle.com> wrote:
>>> 
>>> On a 32 bit system, the "len * sizeof(*p)" operation can have an
>>> integer overflow.
>>> 
>>> c: stable@vger.kernel.org
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> 
>> Trond, this patch was To: me, but either you or I can take this.
>> Please let me know your preference.
>> 
> 
> I don't mind either way. If you've got it applied already, then let's
> send it through your tree.

I've applied this one and "prevent underflow in nfssvc_decode_writeargs".
Thanks, Trond and Dan!


--
Chuck Lever




      reply	other threads:[~2022-03-15 16:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 15:34 [PATCH v2] NFSD: prevent integer overflow on 32 bit systems Dan Carpenter
2022-03-15 16:22 ` Chuck Lever III
2022-03-15 16:30   ` Trond Myklebust
2022-03-15 16:39     ` Chuck Lever III [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AC86875-3CBC-4DA7-BAB2-46DA35324842@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=anna@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox