From: Jeff Layton <jlayton@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>,
Chuck Lever <chuck.lever@oracle.com>
Cc: NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 0/2] nfsd: Fix cred refcount leak.
Date: Sat, 24 Jan 2026 10:32:32 -0500 [thread overview]
Message-ID: <5aea2cd26cf9d0d8c55ca2f95cf06b3224020f61.camel@kernel.org> (raw)
In-Reply-To: <20260124041902.548904-1-kuniyu@google.com>
On Sat, 2026-01-24 at 04:18 +0000, Kuniyuki Iwashima wrote:
> get_current_cred() is misused in nfsd_nl_listener_set_doit()
> and nfsd_nl_threads_set_doit(), leaking the cred refcount.
>
> Patch 1 & 2 fixes the leak in each function.
>
>
> Kuniyuki Iwashima (2):
> nfsd: Fix cred ref leak in nfsd_nl_threads_set_doit().
> nfsd: Fix cred ref leak in nfsd_nl_listener_set_doit().
>
> fs/nfsd/nfsctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Nice catch.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2026-01-24 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 4:18 [PATCH v1 0/2] nfsd: Fix cred refcount leak Kuniyuki Iwashima
2026-01-24 4:18 ` [PATCH v1 1/2] nfsd: Fix cred ref leak in nfsd_nl_threads_set_doit() Kuniyuki Iwashima
2026-01-24 4:18 ` [PATCH v1 2/2] nfsd: Fix cred ref leak in nfsd_nl_listener_set_doit() Kuniyuki Iwashima
2026-01-24 15:32 ` Jeff Layton [this message]
2026-01-25 3:21 ` [PATCH v1 0/2] nfsd: Fix cred refcount leak Chuck Lever
2026-02-28 20:01 ` Kuniyuki Iwashima
2026-02-28 20:36 ` Chuck Lever
2026-02-28 20:39 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aea2cd26cf9d0d8c55ca2f95cf06b3224020f61.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=linux-nfs@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox