Re: [PATCH v1 0/2] nfsd: Fix cred refcount leak.

Kuniyuki Iwashima
2026-02-28T20:40:02Z

On Sat, Feb 28, 2026 at 12:37 PM Chuck Lever <cel@kernel.org> wrote:
>
> On Sat, Feb 28, 2026, at 3:01 PM, Kuniyuki Iwashima wrote:
> > Hi Chuck,
> >
> > From: Chuck Lever <cel@kernel.org>
> > Date: Sat, 24 Jan 2026 22:21:05 -0500
> >> From: Chuck Lever <chuck.lever@oracle.com>
> >>
> >> On Sat, 24 Jan 2026 04:18:39 +0000, Kuniyuki Iwashima wrote:
> >> > get_current_cred() is misused in nfsd_nl_listener_set_doit()
> >> > and nfsd_nl_threads_set_doit(), leaking the cred refcount.
> >> >
> >> > Patch 1 & 2 fixes the leak in each function.
> >> >
> >> >
> >> > Kuniyuki Iwashima (2):
> >> > nfsd: Fix cred ref leak in nfsd_nl_threads_set_doit().
> >> > nfsd: Fix cred ref leak in nfsd_nl_listener_set_doit().
> >> >
> >> > [...]
> >>
> >> Applied to nfsd-testing, thanks!
> >>
> >> [1/2] nfsd: Fix cred ref leak in nfsd_nl_threads_set_doit().
> >> commit: c14b0c3b5966a1e2cf6a7f219c4f4b3fafeb89d0
> >> [2/2] nfsd: Fix cred ref leak in nfsd_nl_listener_set_doit().
> >> commit: 687b9b69fcda9de606e998fd2edccb8a14406e19
> >
> > While rebasing my local branch, I just noticed both patches
> > are not in the mainline and I couldn't find both SHA1 in your
> > tree.
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?id=c14b0c3b5966a1e2cf6a7f219c4f4b3fafeb89d0
> >
> > Could you double check ?
>
> The patches are in my nfsd-fixes branch. I'm planning to submit them
> soon for 7.0-rc .

Sounds good, sorry for bothering you, and thank you for checking !