Re: [PATCH] NFS: Fix missing unlock in nfs_unlink()

[Sun Ke <sunke32@huawei.com>]

friendly ping...

在 2022/8/12 9:14, Sun Ke 写道:
> Add the missing unlock before goto.
> 
> Fixes: 3c59366c207e ("NFS: don't unhash dentry during unlink/rename")
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
>   fs/nfs/dir.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index dbab3caa15ed..1b879584d4fe 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -2484,8 +2484,10 @@ int nfs_unlink(struct inode *dir, struct dentry *dentry)
>   	 */
>   	error = -ETXTBSY;
>   	if (WARN_ON(dentry->d_flags & DCACHE_NFSFS_RENAMED) ||
> -	    WARN_ON(dentry->d_fsdata == NFS_FSDATA_BLOCKED))
> +	    WARN_ON(dentry->d_fsdata == NFS_FSDATA_BLOCKED)) {
> +		spin_unlock(&dentry->d_lock);
>   		goto out;
> +	}
>   	if (dentry->d_fsdata)
>   		/* old devname */
>   		kfree(dentry->d_fsdata);
>