From: Steve Dickson <SteveD@RedHat.com>
To: Ryan Doyle <rdoyle@aconex.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs-utils: display NFS RPC queue time for mountstats and nfs-iostat
Date: Mon, 30 Oct 2017 11:29:45 -0400 [thread overview]
Message-ID: <60e01567-070d-c7db-b26f-b290df0d3cc0@RedHat.com> (raw)
In-Reply-To: <MEXPR01MB0711C64DC23E94EE366C5455A2590@MEXPR01MB0711.ausprd01.prod.outlook.com>
On 10/29/2017 11:30 PM, Ryan Doyle wrote:
> Hi there
>
> I've got a patch to display the NFS queue statistics for mountstats and nfsiostat exported in /proc/self/mountstats. The RTT and total execution time is currently displayed but I think it's also useful displaying how long the task was queued for too. If others agree, please feel free to apply it.
In the future please use the proper format for posting
a patch that is described in
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html
Basically, inline the patch, have a subject and description
section and a proper Signed-off-by: line. But since I
found another bug while testing your patch and I'm about
to make a release I'll go ahead and add the Signed-off-by: line
Patch committed!
steved.
prev parent reply other threads:[~2017-10-30 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 3:30 [PATCH] nfs-utils: display NFS RPC queue time for mountstats and nfs-iostat Ryan Doyle
2017-10-30 15:29 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e01567-070d-c7db-b26f-b290df0d3cc0@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rdoyle@aconex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).