Re: [PATCH 0/2] netfs: Fix use of fscache with ceph

[Paulo Alcantara <pc@manguebit.org>]

David Howells <dhowells@redhat.com> writes:

> Hi Christian,
>
> Here are a couple of patches that fix the use of fscaching with ceph:
>
>  (1) Fix the read collector to mark the write request that it creates to copy
>      data to the cache with NETFS_RREQ_OFFLOAD_COLLECTION so that it will run
>      the write collector on a workqueue as it's meant to run in the background
>      and the app isn't going to wait for it.
>
>  (2) Fix the read collector to wake up the copy-to-cache write request after
>      it sets NETFS_RREQ_ALL_QUEUED if the write request doesn't have any
>      subrequests left on it.  ALL_QUEUED indicates that there won't be any
>      more subreqs coming and the collector should clean up - except that an
>      event is needed to trigger that, but it only gets events from subreq
>      termination and so the last event can beat us to setting ALL_QUEUED.
>
> The patches can also be found here:
>
> 	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
>
> Thanks,
> David
>
> David Howells (2):
>   netfs: Fix copy-to-cache so that it performs collection with
>     ceph+fscache
>   netfs: Fix race between cache write completion and ALL_QUEUED being
>     set
>
>  fs/netfs/read_pgpriv2.c      |  5 +++++
>  include/trace/events/netfs.h | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+)

Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>