Re: [PATCH v5 0/2] add rpc_status handler in nfsd debug filesystem

[Jeff Layton <jlayton@kernel.org>]

On Fri, 2023-08-04 at 19:16 +0200, Lorenzo Bianconi wrote:
> Introduce rpc_status entry in nfsd debug filesystem in order to dump
> pending RPC requests debugging information.
> 
> Changes since v4:
> - rely on acquire/release APIs and get rid of atomic operation
> - fix kdoc for nfsd_rpc_status_open
> - get rid of ',' as field delimiter in nfsd_rpc_status hanlder
> - move nfsd_rpc_status before nfsd_v4 enum entries
> - fix compilantion error if nfsdv4 is not enabled
> 
> Changes since v3:
> - introduce rq_status_counter in order to detect if the RPC request is
>   pending and RPC info are stable
> - rely on __svc_print_addr to dump IP info
> 
> Changes since v2:
> - minor changes in nfsd_rpc_status_show output
> 
> Changes since v1:
> - rework nfsd_rpc_status_show output
> 
> Changes since RFCv1:
> - riduce time holding nfsd_mutex bumping svc_serv refcoung in
>   nfsd_rpc_status_open()
> - dump rqstp->rq_stime
> - add missing kdoc for nfsd_rpc_status_open()
> 
> Link: https://bugzilla.linux-nfs.org/show_bug.cgi?id=3D366
> 
> Lorenzo Bianconi (2):
>   SUNRPC: add verbose parameter to __svc_print_addr()
>   NFSD: add rpc_status entry in nfsd debug filesystem
> 
>  fs/nfsd/nfs4proc.c              |   4 +-
>  fs/nfsd/nfsctl.c                |   9 ++
>  fs/nfsd/nfsd.h                  |   7 ++
>  fs/nfsd/nfssvc.c                | 140 ++++++++++++++++++++++++++++++++
>  include/linux/sunrpc/svc.h      |   1 +
>  include/linux/sunrpc/svc_xprt.h |  12 +--
>  net/sunrpc/svc.c                |   2 +-
>  net/sunrpc/svc_xprt.c           |   2 +-
>  8 files changed, 166 insertions(+), 11 deletions(-)
> 

Reviewed-by: Jeff Layton <jlayton@kernel.org>