From: Steve Dickson <SteveD@RedHat.com>
To: Scott Mayhew <smayhew@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils RFC PATCH 2/2] gssd: add timeout for upcall threads
Date: Thu, 27 May 2021 11:36:49 -0400 [thread overview]
Message-ID: <64b6f93a-e81c-fd8a-8db5-44e69004294d@RedHat.com> (raw)
In-Reply-To: <490b45eb-0142-24de-e05f-79751891ddf9@RedHat.com>
Hey!
Off-list...
On 5/26/21 1:08 PM, Steve Dickson wrote:
>> + free(tinfo);
>> + return ret;
>> + }
>> + printerr(1, "created thread id 0x%lx\n", th);
> This will be removed...
It turns out this tid is useful since the
tid is used in the do_downcall() db statement.
In general I've try to always used the function name
in the db statement so it is know where it is.
So maybe something like this:
pthread_t tid = pthread_self();
printerr(2, "start_upcall_thread(0x%lx): created thread id 0x%lx\n", tid, th);
steved.
P.S. After your final version, I'm going to follow up with a debug clean up
patch... So I can take care of it there... if you like.
next prev parent reply other threads:[~2021-05-27 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 18:00 [nfs-utils RFC PATCH 0/2] Two rpc.gssd improvements Scott Mayhew
2021-05-25 18:00 ` [nfs-utils RFC PATCH 1/2] gssd: deal with failed thread creation Scott Mayhew
2021-05-25 19:15 ` Steve Dickson
2021-05-25 20:53 ` Scott Mayhew
2021-05-25 18:00 ` [nfs-utils RFC PATCH 2/2] gssd: add timeout for upcall threads Scott Mayhew
2021-05-26 17:08 ` Steve Dickson
2021-05-26 17:11 ` Chuck Lever III
2021-05-27 12:01 ` Scott Mayhew
2021-05-27 11:40 ` Scott Mayhew
2021-05-27 12:54 ` Steve Dickson
2021-05-27 16:47 ` Olga Kornievskaia
2021-05-30 19:54 ` Steve Dickson
2021-05-27 15:36 ` Steve Dickson [this message]
2021-05-27 16:49 ` Scott Mayhew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b6f93a-e81c-fd8a-8db5-44e69004294d@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox