Re: [nfs-utils PATCH v2 0/2] nfsdctl version handling fixes

[Jeff Layton <jlayton@kernel.org>]

On Fri, 2025-01-10 at 15:17 -0500, Scott Mayhew wrote:
> Two changes in how nfsdctl does version handling.  The first patch makes
> the 'nfsdctl version' command behave according to the man page for w.r.t
> handling +4/-4, e.g.
> 
> # utils/nfsdctl/nfsdctl
> nfsdctl> threads 0
> nfsdctl> version
> +3.0 +4.0 +4.1 +4.2
> nfsdctl> version -4
> nfsdctl> version
> +3.0 -4.0 -4.1 -4.2
> nfsdctl> version +4
> nfsdctl> version
> +3.0 +4.0 +4.1 +4.2
> nfsdctl> version -4 +4.2
> nfsdctl> version
> +3.0 -4.0 -4.1 +4.2
> nfsdctl> ^D
> 
> The second patch makes nfsdctl's handling of the nfsd version options in
> nfs.conf behave like rpc.nfsd's.  This is important since the systemd
> service file will fall back to rpc.nfsd if nfsdctl fails.  I'll send a
> test script and test results in a followup email.
> 
> -Scott
> 
> Scott Mayhew (2):
>   nfsdctl: tweak the version subcommand behavior
>   nfsdctl: tweak the nfs.conf version handling
> 
>  utils/nfsdctl/nfsdctl.c | 69 +++++++++++++++++++++++++++++++++++------
>  1 file changed, 59 insertions(+), 10 deletions(-)
> 

LGTM!

Reviewed-by: Jeff Layton <jlayton@kernel.org>