Re: rpc.idmapd runs out of file descriptors

[Steve Dickson <steved@redhat.com>]

On 9/16/24 2:18 PM, Salvatore Bonaccorso wrote:
> dirscancb() loops over all clnt* subdirectories of/run/rpc_pipefs/nfs/.
> Some of these directories contain /idmap files, others don't. nfsopen()
> returns -1 for the latter; we then want to skip the directory, not abort
> the entire scan.
> 
> Reported-by: Sergio Gelato<sergio.gelato@astro.su.se>
> Closes:https://lore.kernel.org/linux-nfs/ZmCB_zqdu2cynJ1M@astro.su.se/
> Link:https://bugs.debian.org/1072573
> Patch-originally-by: Sergio Gelato<sergio.gelato@astro.su.se>
> Signed-off-by: Salvatore Bonaccorso<carnil@debian.org>
Committed... (tag: nfs-utils-2-7-2-rc1)

steved.
> ---
> Changes in v2:
> - Fix typo in URL for Debian bug reference
> - Reorder patch tags and use Closes tag after Reported-by
> 
>   utils/idmapd/idmapd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index cd9a965f8fbc..5231f56d24a8 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -556,7 +556,7 @@ dirscancb(int fd, short UNUSED(which), void *data)
>   			if (nfsopen(ic) == -1) {
>   				close(ic->ic_dirfd);
>   				free(ic);
> -				goto out;
> +				continue;
>   			}
>   
>   			if (verbose > 2)
> --