From: Dan Williams <dan.j.williams@intel.com>
To: Anna Schumaker <anna@kernel.org>, <linux-nfs@vger.kernel.org>,
<trond.myklebust@hammerspace.com>
Cc: <anna@kernel.org>
Subject: Re: [PATCH] NFS: Fix NFS KConfig typos
Date: Thu, 12 Mar 2026 15:01:16 -0700 [thread overview]
Message-ID: <69b337ac4589_2132100e7@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20260227204231.769675-1-anna@kernel.org>
Anna Schumaker wrote:
> From: Anna Schumaker <anna.schumaker@oracle.com>
>
> Two issues were noticed after the NFS v4.0 KConfig changes were merged
> upstream. First, the text of CONFIG_NFS_V4 should not encourage people
> to select it if they are unsure. Second, the new CONFIG_NFS_V4_0 option
> should default to "on" instead of "off" to avoid breaking people's
> setups if they are using NFS v4.0.
>
> Reported-by: Niklas Cassel <cassel@kernel.org>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Fixes: 4e0269352534 ("NFS: Add a way to disable NFS v4.0 via KConfig")
> Fixes: 7537db24806f ("NFS: Merge CONFIG_NFS_V4_1 with CONFIG_NFS_V4")
Can confirm that this commit, 7537db24806f, regressed my long standing
NFS boot configuration.
Can also confirm that had this proposed fix been in the tree before I
did my first post v7.0-rc1 build it would have saved me a bisect.
Unfortunately, anyone like me that did a post v7.0-rc1 build with "make
olddefconfig" will not enjoy any relief until they clean out the errant:
# CONFIG_NFS_V4_0 is not set
...so that the default can be applied.
Not sure of any good way to address that problem, but for this patch:
Tested-by: Dan Williams <dan.j.williams@intel.com>
BTW, I had to lookup this thread the old fashioned way, a
patches.msgid.link tag would have saved a few moments. No worries if
this is not standard NFS subsystem policy.
prev parent reply other threads:[~2026-03-12 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 20:42 [PATCH] NFS: Fix NFS KConfig typos Anna Schumaker
2026-03-12 22:01 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b337ac4589_2132100e7@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox