From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4784C3CFF61 for ; Mon, 6 Jul 2026 16:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783353653; cv=none; b=oxFBaHkwDKcprukl90kCbuLPGqxjaFqySZglIVHNXOet63uJICbzh6xRrjEruTZSVXe5Amexv1BGN+s46xAAMiQ+l1E/ww5qZbFNmFUpEpLYKPQioYK6/FouMmBcSxHMHO+HReAHH8/WQGHv77M1ymSZy3st01O1BkRqmUBiTKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783353653; c=relaxed/simple; bh=m8rJDUzyUn05W0QRPU8lSyncO+wlBewjmX+ATagl7Yc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CT3/ibLFzbzER72JaSc+82aB/yCZx0K+Rr0RCme6ziBXfUGLLQ5pH7JCrGgZRT2XCgq/4jgvpG1F+Cc9jiTxKlHadPM9VeWmnBbimKVsM8NbvvgrROCrwtykMZalMxSxpod6X8WAz80+aV6d/ayySBxG5viHZcJCGO6n5jxJ+e4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T7UMGwPo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T7UMGwPo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B5781F000E9; Mon, 6 Jul 2026 16:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783353651; bh=y3FfNzNfM1FiPnAdcUa0yzR1KDzQD55Xa2OBGCIebjc=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=T7UMGwPobyq1LUmw39XmOxMeJf6hKKkcltWtrFTp6OqmVG0nskxTt9YJOUXdE2Yzs BRSyrdb2EZ/ukAe0b12AVlfcHmi8MXOq1jMWTuZ/HHFoCFK3LhxCMetRAoNKt83l5W MvQwHqGaRAaQKNlIixXTOslH6eH2spXsx3EFpMSMJv9/TWeW9LTAaQdX5u7HbuswGh F5Su7ZfWdhd+U6WLzHyt1NwUDvcrrl7AbXifLuntsuxqxv/r5blNB1SyOkILfCXaBn ECBU4K+AU/q0flp12fSzX4uy5U4rwna/tQlxnp/9vETUdwLyNY+q3TVLXkatzpaVPh 7kZ7rY0CsII+w== Message-ID: <6f9f29157871d413bcef1531653b2d6811d8aa02.camel@kernel.org> Subject: Re: [PATCH v2 13/14] nfsd: separate out VFS-specific from from nfsd4_create_file() From: Jeff Layton To: NeilBrown , Chuck Lever Cc: Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org Date: Mon, 06 Jul 2026 12:00:49 -0400 In-Reply-To: <20260705222032.1240057-14-neilb@ownmail.net> References: <20260705222032.1240057-1-neilb@ownmail.net> <20260705222032.1240057-14-neilb@ownmail.net> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-07-06 at 08:19 +1000, NeilBrown wrote: > From: NeilBrown >=20 > All the code in nfsd4_create_file() that is VFS manipulation, with now > NFS-specific knowledge, has been localised. Now we split that out into > a separate function: do_lookup_open(). >=20 > It is planned to provide a vfs_lookup_open() in vfs code which provides > this functionality. This will share more code with the syscall open > path, and make it easier to modify locking at the VFS level. >=20 > Signed-off-by: NeilBrown > --- > fs/nfsd/nfs4proc.c | 108 ++++++++++++++++++++++++--------------------- > 1 file changed, 58 insertions(+), 50 deletions(-) >=20 > diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c > index 10323c620b71..643cf4302db5 100644 > --- a/fs/nfsd/nfs4proc.c > +++ b/fs/nfsd/nfs4proc.c > @@ -201,6 +201,47 @@ static inline bool nfsd4_create_is_exclusive(int cre= atemode) > createmode =3D=3D NFS4_CREATE_EXCLUSIVE4_1; > } > =20 > +static struct file *do_lookup_open(struct path *parent, > + struct qstr *name, > + unsigned int oflags, > + umode_t mode) > +{ > + struct file *filp =3D NULL; > + struct path path; > + struct dentry *child; > + int error =3D 0; > + > + error =3D mnt_want_write(parent->mnt); > + > + if (error) > + return ERR_PTR(error); > + > + child =3D start_creating(&nop_mnt_idmap, parent->dentry, name); > + if (IS_ERR(child)) { > + filp =3D ERR_CAST(child); > + goto out; > + } > + path.mnt =3D parent->mnt; > + path.dentry =3D child; > + > + if (d_really_is_positive(child)) { > + /* > + * open the file so that, unless it is O_RDONLY, we > + * have write-access to the fs for setattr below. > + */ > + filp =3D dentry_open(&path, oflags, current_cred()); > + } else if (!(oflags & O_CREAT)) { > + filp =3D ERR_PTR(-ENOENT); > + } else { > + filp =3D dentry_create(&path, oflags, mode, current_cred()); > + child =3D path.dentry; > + } > + end_creating(child); > +out: > + mnt_drop_write(parent->mnt); > + return filp; > +} > + > /* > * Implement NFSv4's unchecked, guarded, and exclusive create > * semantics for regular files. Open state for this new file is > @@ -218,14 +259,13 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct sv= c_fh *fhp, > .na_seclabel =3D &open->op_label, > }; > int oflags =3D O_CREAT | O_LARGEFILE; > - struct dentry *parent, *child =3D ERR_PTR(-EINVAL); > - struct path path =3D { > + struct dentry *child =3D ERR_PTR(-EINVAL); > + struct path parent =3D { > .mnt =3D fhp->fh_export->ex_path.mnt, > + .dentry =3D fhp->fh_dentry, > }; > __u32 v_mtime, v_atime; > - struct inode *inode; > __be32 status, create_status; > - int host_err; > =20 > if (name_is_dot_dotdot(open->op_fname, open->op_fnamelen)) > return nfserr_exist; > @@ -235,10 +275,8 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc= _fh *fhp, > status =3D fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_EXEC); > if (status !=3D nfs_ok) > return status; > - parent =3D fhp->fh_dentry; > - inode =3D d_inode(parent); > =20 > - if (!IS_POSIXACL(inode)) > + if (!IS_POSIXACL(d_inode(parent.dentry))) > iap->ia_mode &=3D ~current_umask(); > =20 > /* > @@ -303,53 +341,23 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct sv= c_fh *fhp, > } > =20 > create_status =3D fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_CREATE); > - > - host_err =3D fh_want_write(fhp); > - if (host_err) { > - status =3D nfserrno(host_err); > - goto out; > - } > - > - child =3D start_creating(&nop_mnt_idmap, parent, > - &QSTR_LEN(open->op_fname, open->op_fnamelen)); > - if (IS_ERR(child)) { > - status =3D nfserrno(PTR_ERR(child)); > - fh_drop_write(fhp); > + if (create_status) > + oflags &=3D ~O_CREAT; > + open->op_filp =3D do_lookup_open(&parent, > + &QSTR_LEN(open->op_fname, > + open->op_fnamelen), > + oflags, > + open->op_iattr.ia_mode); > + if (IS_ERR(open->op_filp)) { > + status =3D nfserrno(PTR_ERR(open->op_filp)); > + open->op_filp =3D NULL; > + if (status =3D=3D NFSERR_NOENT && create_status) > + status =3D create_status; > goto out; > } >=20 My Claude spotted this: Should this compare against nfserr_noent rather than NFSERR_NOENT? status is __be32, and it is assigned from nfserrno(-ENOENT), which returns nfserr_noent. --=20 Jeff Layton