From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: linux-nfs@vger.kernel.org
Cc: "Jeff Layton" <jlayton@redhat.com>,
"Steve Dickson" <steved@redhat.com>,
"Ulrich Ölmann" <u.oelmann@pengutronix.de>
Subject: Re: [PATCH nfs-utils] nfsd: clean up option parsing
Date: Wed, 16 Dec 2020 15:28:01 +0100 [thread overview]
Message-ID: <6rbletbzbi.fsf@pengutronix.de> (raw)
In-Reply-To: <20201209120643.14427-1-u.oelmann@pengutronix.de>
Gentle ping!
(And putting Jeff & Steve on CC).
On Wed, Dec 09 2020 at 13:06 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Presumably by mistake in commit [1] the unknown option 'i' slipped in together
> with a duplicated 't', so remove them from the optstring.
>
> [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default")
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
> utils/nfsd/nfsd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
> index a412a026c6c5..c9f0385b5a00 100644
> --- a/utils/nfsd/nfsd.c
> +++ b/utils/nfsd/nfsd.c
> @@ -162,7 +162,7 @@ main(int argc, char **argv)
> }
> }
>
> - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) {
> + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) {
> switch(c) {
> case 'd':
> xlog_config(D_ALL, 1);
--
Pengutronix e.K. | Ulrich Ölmann |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-12-16 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 12:06 [PATCH nfs-utils] nfsd: clean up option parsing Ulrich Ölmann
2020-12-16 14:28 ` Ulrich Ölmann [this message]
2020-12-16 16:14 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6rbletbzbi.fsf@pengutronix.de \
--to=u.oelmann@pengutronix.de \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox