From: David Howells <dhowells@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: dhowells@redhat.com, jmorris@namei.org,
Scott Mayhew <smayhew@redhat.com>,
keyrings@linux-nfs.org, Dave Wysochanski <dwysocha@redhat.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] KEYS: Fix a race between negating a key and reading the error set
Date: Fri, 11 Oct 2013 23:51:46 +0100 [thread overview]
Message-ID: <7165.1381531906@warthog.procyon.org.uk> (raw)
In-Reply-To: <20131011151402.33dfe46e@tlielax.poochiereds.net>
Jeff Layton <jlayton@redhat.com> wrote:
> > - if (kflags & (1 << KEY_FLAG_NEGATIVE))
> > + if (kflags & (1 << KEY_FLAG_NEGATIVE)) {
>
> Not specifically related to this bug, but why are you open-coding
> test_bit() here and elsewhere?
Because kflags is read once and kept in a variable. Might not be necessary -
and I should probably use ACCESS_ONCE() when I do.
David
next prev parent reply other threads:[~2013-10-11 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 16:16 [PATCH] KEYS: Fix a race between negating a key and reading the error set David Howells
2013-10-11 19:14 ` Jeff Layton
2013-10-11 22:51 ` David Howells [this message]
2013-10-15 15:49 ` David Wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7165.1381531906@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=jlayton@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).