From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: <andros@netapp.com>, <trondmy@primarydata.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH Version 9 RESEND 11/12] NFS test session trunking with exchange id
Date: Thu, 8 Sep 2016 10:52:17 -0400 [thread overview]
Message-ID: <73a1d5d6-4358-bf66-d3d0-81e045bed1ae@Netapp.com> (raw)
In-Reply-To: <1472744693-124241-12-git-send-email-andros@netapp.com>
Hi Andy,
On 09/01/2016 11:44 AM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> Use an async exchange id call to test for session trunking
>
> To conform with RFC 5661 section 18.35.4, the Non-Update on
> Existing Clientid case, save the exchange id verifier in
> cl_confirm and use it for the session trunking exhange id test.
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
> fs/nfs/nfs4_fs.h | 5 +++++
> fs/nfs/nfs4client.c | 7 +++++--
> fs/nfs/nfs4proc.c | 45 +++++++++++++++++++++++++++++++++++++--------
> 3 files changed, 47 insertions(+), 10 deletions(-)
>
> diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> index eb315e1..b2a94ca 100644
> --- a/fs/nfs/nfs4_fs.h
> +++ b/fs/nfs/nfs4_fs.h
> @@ -203,6 +203,11 @@ struct nfs4_state_recovery_ops {
> struct rpc_cred *);
> };
>
> +struct nfs4_add_xprt_data {
> + struct nfs_client *clp;
> + struct rpc_cred *cred;
> +};
Looks like this doesn't get used until the next patch. Can you add it there instead of here?
Thanks,
Anna
> +
> struct nfs4_state_maintenance_ops {
> int (*sched_state_renewal)(struct nfs_client *, struct rpc_cred *, unsigned);
> struct rpc_cred * (*get_state_renewal_cred_locked)(struct nfs_client *);
> diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
> index 4e15ae1..71cf59d 100644
> --- a/fs/nfs/nfs4client.c
> +++ b/fs/nfs/nfs4client.c
> @@ -638,8 +638,8 @@ out_scope_mismatch:
>
> /**
> * nfs4_detect_session_trunking - Checks for session trunking called
> - * after a successful EXCHANGE_ID testing a multi-addr connection to be
> - * potentially added as a session trunk
> + * after a successful EXCHANGE_ID testing a multi-addr connection.
> + * Upon success, add the transport.
> *
> * @clp: original mount nfs_client
> * @res: result structure from an exchange_id using the original mount
> @@ -674,6 +674,9 @@ int nfs4_detect_session_trunking(struct nfs_client *clp,
> if (!nfs4_check_server_scope(clp->cl_serverscope, res->server_scope))
> goto out;
>
> + /* Session trunking passed, add the xprt */
> + rpc_clnt_xprt_switch_add_xprt(clp->cl_rpcclient, xprt);
> +
> status = 0;
> out:
> if (status)
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index e29f5ce..7b5000a 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -7054,6 +7054,7 @@ static int nfs4_sp4_select_mode(struct nfs_client *clp,
> struct nfs41_exchange_id_data {
> struct nfs41_exchange_id_res res;
> struct nfs41_exchange_id_args args;
> + struct rpc_xprt *xprt;
> int rpc_status;
> };
>
> @@ -7068,6 +7069,13 @@ static void nfs4_exchange_id_done(struct rpc_task *task, void *data)
>
> if (status == 0)
> status = nfs4_check_cl_exchange_flags(cdata->res.flags);
> +
> + if (cdata->xprt && status == 0) {
> + status = nfs4_detect_session_trunking(clp, &cdata->res,
> + cdata->xprt);
> + goto out;
> + }
> +
> if (status == 0)
> status = nfs4_sp4_select_mode(clp, &cdata->res.state_protect);
>
> @@ -7104,8 +7112,13 @@ static void nfs4_exchange_id_done(struct rpc_task *task, void *data)
> clp->cl_serverscope = cdata->res.server_scope;
> cdata->res.server_scope = NULL;
> }
> + /* Save the EXCHANGE_ID verifier session trunk tests */
> + memcpy(clp->cl_confirm.data, cdata->args.verifier->data,
> + sizeof(clp->cl_confirm.data));
> }
> +out:
> cdata->rpc_status = status;
> + return;
> }
>
> static void nfs4_exchange_id_release(void *data)
> @@ -7114,6 +7127,10 @@ static void nfs4_exchange_id_release(void *data)
> (struct nfs41_exchange_id_data *)data;
>
> nfs_put_client(cdata->args.client);
> + if (cdata->xprt) {
> + xprt_put(cdata->xprt);
> + rpc_clnt_xprt_switch_put(cdata->args.client->cl_rpcclient);
> + }
> kfree(cdata->res.impl_id);
> kfree(cdata->res.server_scope);
> kfree(cdata->res.server_owner);
> @@ -7131,7 +7148,7 @@ static const struct rpc_call_ops nfs4_exchange_id_call_ops = {
> * Wrapper for EXCHANGE_ID operation.
> */
> static int _nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred,
> - u32 sp4_how)
> + u32 sp4_how, struct rpc_xprt *xprt)
> {
> nfs4_verifier verifier;
> struct rpc_message msg = {
> @@ -7156,7 +7173,8 @@ static int _nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred,
> if (!calldata)
> goto out;
>
> - nfs4_init_boot_verifier(clp, &verifier);
> + if (!xprt)
> + nfs4_init_boot_verifier(clp, &verifier);
>
> status = nfs4_init_uniform_client_string(clp);
> if (status)
> @@ -7196,8 +7214,15 @@ static int _nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred,
> status = -EINVAL;
> goto out_impl_id;
> }
> -
> - calldata->args.verifier = &verifier;
> + if (xprt) {
> + calldata->xprt = xprt;
> + task_setup_data.rpc_xprt = xprt;
> + task_setup_data.flags =
> + RPC_TASK_SOFT|RPC_TASK_SOFTCONN|RPC_TASK_ASYNC;
> + calldata->args.verifier = &clp->cl_confirm;
> + } else {
> + calldata->args.verifier = &verifier;
> + }
> calldata->args.client = clp;
> #ifdef CONFIG_NFS_V4_1_MIGRATION
> calldata->args.flags = EXCHGID4_FLAG_SUPP_MOVED_REFER |
> @@ -7217,9 +7242,13 @@ static int _nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred,
> goto out_impl_id;
> }
>
> - status = rpc_wait_for_completion_task(task);
> - if (!status)
> + if (!xprt) {
> + status = rpc_wait_for_completion_task(task);
> + if (!status)
> + status = calldata->rpc_status;
> + } else /* session trunking test */
> status = calldata->rpc_status;
> +
> rpc_put_task(task);
> out:
> if (clp->cl_implid != NULL)
> @@ -7262,13 +7291,13 @@ int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred)
> /* try SP4_MACH_CRED if krb5i/p */
> if (authflavor == RPC_AUTH_GSS_KRB5I ||
> authflavor == RPC_AUTH_GSS_KRB5P) {
> - status = _nfs4_proc_exchange_id(clp, cred, SP4_MACH_CRED);
> + status = _nfs4_proc_exchange_id(clp, cred, SP4_MACH_CRED, NULL);
> if (!status)
> return 0;
> }
>
> /* try SP4_NONE */
> - return _nfs4_proc_exchange_id(clp, cred, SP4_NONE);
> + return _nfs4_proc_exchange_id(clp, cred, SP4_NONE, NULL);
> }
>
> static int _nfs4_proc_destroy_clientid(struct nfs_client *clp,
>
next prev parent reply other threads:[~2016-09-08 14:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 15:44 [PATCH Version 9 RESEND 00/12] pNFS file layout session trunking andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 01/12] NFS setup async exchange_id andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 02/12] NFS refactor nfs4_match_clientids andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 03/12] NFS refactor nfs4_check_serverowner_major_id andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 04/12] NFS detect session trunking andros
2016-09-07 20:47 ` Anna Schumaker
2016-09-01 15:44 ` [PATCH Version 9 RESEND 05/12] SUNRPC remove rpc_task_release_client from rpc_task_set_client andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 06/12] SUNRPC rpc_clnt_xprt_switch_put andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 07/12] SUNRPC rpc_clnt_xprt_switch_add_xprt andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 08/12] SUNRPC search xprt switch for sockaddr andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 09/12] SUNRPC: rpc_clnt_add_xprt setup function for NFS layer andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 10/12] NFS add xprt switch addrs test to match client andros
2016-09-01 15:44 ` [PATCH Version 9 RESEND 11/12] NFS test session trunking with exchange id andros
2016-09-08 14:52 ` Anna Schumaker [this message]
2016-09-01 15:44 ` [PATCH Version 9 RESEND 12/12] NFS pnfs data server multipath session trunking andros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a1d5d6-4358-bf66-d3d0-81e045bed1ae@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).