From: Jeff Layton <jlayton@kernel.org>
To: Ross Burton <ross.burton@arm.com>, linux-nfs@vger.kernel.org
Cc: steved@redhat.com
Subject: Re: [PATCH] locktest: use correct build flags
Date: Mon, 17 Nov 2025 10:33:37 -0500 [thread overview]
Message-ID: <749b345a16b9e799c953554491493d55d3fa1ca5.camel@kernel.org> (raw)
In-Reply-To: <20251117143241.1501312-1-ross.burton@arm.com>
On Mon, 2025-11-17 at 14:32 +0000, Ross Burton wrote:
> This makefile uses CFLAGS_FOR_BUILD etc but since 2020[1] hasn't used
> CC_FOR_BUILD as CC.
>
> This means in cross-compile environments this uninstalled binary is
> built for the host machine using build machine flags, which can result
> in incorrect paths being passed.
>
> As this binary hasn't been built with CC_FOR_BUILD for five years, we
> can assume that this isn't actually used and just remove the _FOR_BUILD
> flags entirely.
>
> Original patch by Khem Raj <raj.khem@gmail.com>.
>
> [1] nfs-utils 1fee8caa ("locktest: Makefile.am: remove host compiler costraint")
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> tools/locktest/Makefile.am | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
> index e8914655..2fd36971 100644
> --- a/tools/locktest/Makefile.am
> +++ b/tools/locktest/Makefile.am
> @@ -2,8 +2,5 @@
>
> noinst_PROGRAMS = testlk
> testlk_SOURCES = testlk.c
> -testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
> -testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
> -testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
>
> MAINTAINERCLEANFILES = Makefile.in
(cc'ing SteveD since he's nfs-utils maintainer)
Acked-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-11-17 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 14:32 [PATCH] locktest: use correct build flags Ross Burton
2025-11-17 15:33 ` Jeff Layton [this message]
2025-11-19 18:22 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=749b345a16b9e799c953554491493d55d3fa1ca5.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ross.burton@arm.com \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox