linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Benjamin Coddington" <bcodding@redhat.com>
To: "Trond Myklebust" <trondmy@primarydata.com>
Cc: "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: sleeping in async RPC task's rpc_call_ops
Date: Thu, 16 Feb 2017 08:29:35 -0500	[thread overview]
Message-ID: <7DDA58DD-BA8F-4BCA-8535-C78782B54FD0@redhat.com> (raw)

Hi Trond,

I understand that it is considered bad form for async tasks to sleep, but I
do not understand why.  Aren't async tasks running as scheduled work, and thus
allowed to sleep?  My understanding is that a workqueue can detect a
sleeping worker and add another, if needed.

The context is that I am coming back around to the problem of having an
unlock wait for I/O to complete in the face of the waiting process catching
a fatal signal, and I wondering why we cannot (for v4) wait on the iocounter
in the async unlock's rpc_call_prepare.

This question is asked in leiu of sending detestable patches.

Ben

                 reply	other threads:[~2017-02-16 13:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7DDA58DD-BA8F-4BCA-8535-C78782B54FD0@redhat.com \
    --to=bcodding@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).