linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>,
	Chuck Lever <chuck.lever@oracle.com>,  Neil Brown <neilb@suse.de>,
	Olga Kornievskaia <kolga@netapp.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: clean up comments over nfs4_client definition
Date: Thu, 08 Feb 2024 06:22:01 -0500	[thread overview]
Message-ID: <7a1a686ee715c24f95148481e08e0b1ddfeb6965.camel@kernel.org> (raw)
In-Reply-To: <20240208080627.1014-1-chenhx.fnst@fujitsu.com>

On Thu, 2024-02-08 at 16:06 +0800, Chen Hanxiao wrote:
> nfsd fault injection has been deprecated since
> commit 9d60d93198c6 ("Deprecate nfsd fault injection")
> and removed by
> commit e56dc9e2949e ("nfsd: remove fault injection code")
> 
> So remove the outdated parts about fault injection.
> 
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
>  fs/nfsd/state.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
> index 41bdc913fa71..2231d9da9bfe 100644
> --- a/fs/nfsd/state.h
> +++ b/fs/nfsd/state.h
> @@ -317,8 +317,8 @@ enum {
>   * 0. If they are not renewed within a lease period, they become eligible for
>   * destruction by the laundromat.
>   *
> - * These objects can also be destroyed prematurely by the fault injection code,
> - * or if the client sends certain forms of SETCLIENTID or EXCHANGE_ID updates.
> + * These objects can also be destroyed prematurely if the client sends certain
> + * forms of SETCLIENTID or EXCHANGE_ID updates.
>   * Care is taken *not* to do this however when the objects have an elevated
>   * refcount.
>   *
> @@ -326,7 +326,7 @@ enum {
>   *
>   * o Each nfs4_clients is also hashed by name (the opaque quantity initially
>   *   sent by the client to identify itself).
> - * 	  
> + *
>   * o cl_perclient list is used to ensure no dangling stateowner references
>   *   when we expire the nfs4_client
>   */

Reviewed-by: Jeff Layton <jlayton@kernel.org>

      reply	other threads:[~2024-02-08 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08  8:06 [PATCH] nfsd: clean up comments over nfs4_client definition Chen Hanxiao
2024-02-08 11:22 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a1a686ee715c24f95148481e08e0b1ddfeb6965.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=chenhx.fnst@fujitsu.com \
    --cc=chuck.lever@oracle.com \
    --cc=kolga@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).