linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nfsd: clean up comments over nfs4_client definition
@ 2024-02-08  8:06 Chen Hanxiao
  2024-02-08 11:22 ` Jeff Layton
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Hanxiao @ 2024-02-08  8:06 UTC (permalink / raw)
  To: Chuck Lever, Jeff Layton, Neil Brown, Olga Kornievskaia, Dai Ngo,
	Tom Talpey
  Cc: linux-nfs

nfsd fault injection has been deprecated since
commit 9d60d93198c6 ("Deprecate nfsd fault injection")
and removed by
commit e56dc9e2949e ("nfsd: remove fault injection code")

So remove the outdated parts about fault injection.

Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
---
 fs/nfsd/state.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
index 41bdc913fa71..2231d9da9bfe 100644
--- a/fs/nfsd/state.h
+++ b/fs/nfsd/state.h
@@ -317,8 +317,8 @@ enum {
  * 0. If they are not renewed within a lease period, they become eligible for
  * destruction by the laundromat.
  *
- * These objects can also be destroyed prematurely by the fault injection code,
- * or if the client sends certain forms of SETCLIENTID or EXCHANGE_ID updates.
+ * These objects can also be destroyed prematurely if the client sends certain
+ * forms of SETCLIENTID or EXCHANGE_ID updates.
  * Care is taken *not* to do this however when the objects have an elevated
  * refcount.
  *
@@ -326,7 +326,7 @@ enum {
  *
  * o Each nfs4_clients is also hashed by name (the opaque quantity initially
  *   sent by the client to identify itself).
- * 	  
+ *
  * o cl_perclient list is used to ensure no dangling stateowner references
  *   when we expire the nfs4_client
  */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] nfsd: clean up comments over nfs4_client definition
  2024-02-08  8:06 [PATCH] nfsd: clean up comments over nfs4_client definition Chen Hanxiao
@ 2024-02-08 11:22 ` Jeff Layton
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2024-02-08 11:22 UTC (permalink / raw)
  To: Chen Hanxiao, Chuck Lever, Neil Brown, Olga Kornievskaia, Dai Ngo,
	Tom Talpey
  Cc: linux-nfs

On Thu, 2024-02-08 at 16:06 +0800, Chen Hanxiao wrote:
> nfsd fault injection has been deprecated since
> commit 9d60d93198c6 ("Deprecate nfsd fault injection")
> and removed by
> commit e56dc9e2949e ("nfsd: remove fault injection code")
> 
> So remove the outdated parts about fault injection.
> 
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
>  fs/nfsd/state.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
> index 41bdc913fa71..2231d9da9bfe 100644
> --- a/fs/nfsd/state.h
> +++ b/fs/nfsd/state.h
> @@ -317,8 +317,8 @@ enum {
>   * 0. If they are not renewed within a lease period, they become eligible for
>   * destruction by the laundromat.
>   *
> - * These objects can also be destroyed prematurely by the fault injection code,
> - * or if the client sends certain forms of SETCLIENTID or EXCHANGE_ID updates.
> + * These objects can also be destroyed prematurely if the client sends certain
> + * forms of SETCLIENTID or EXCHANGE_ID updates.
>   * Care is taken *not* to do this however when the objects have an elevated
>   * refcount.
>   *
> @@ -326,7 +326,7 @@ enum {
>   *
>   * o Each nfs4_clients is also hashed by name (the opaque quantity initially
>   *   sent by the client to identify itself).
> - * 	  
> + *
>   * o cl_perclient list is used to ensure no dangling stateowner references
>   *   when we expire the nfs4_client
>   */

Reviewed-by: Jeff Layton <jlayton@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-08 11:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-08  8:06 [PATCH] nfsd: clean up comments over nfs4_client definition Chen Hanxiao
2024-02-08 11:22 ` Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).