linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-omap@vger.kernel.org, linux-nfs@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: RE: Regression seen when HIGHMEM enabled with NFS on 3.1rc4 kernel
Date: Tue, 13 Sep 2011 12:11:09 +0530	[thread overview]
Message-ID: <7c29a4c977b98cf95ef8c7f69e094896@mail.gmail.com> (raw)
In-Reply-To: <1315842858.15975.2.camel@lade.trondhjem.org>

[..]
>>
>> Can you please tell me what the mount options are for this setup?
>
>I'm guessing you've got wsize=1024, in which case, can you please try
>the following patch?
>
The mount options for nfs is rw.

Yes, in my setup wsize=1024 when the issue happened.
I tried your patch and I was not able to see the issue after that,
where as in the other case the issue happened quite frequently.
So I think that the patch fixes the issue.
Thanks a lot for your help.

>Cheers
>  Trond
>8<-----------------------------------------------------------------------
--
>-
>From 7b4a9c76b55dd254431902552528137a2ea5e55d Mon Sep 17 00:00:00 2001
>From: Trond Myklebust <Trond.Myklebust@netapp.com>
>Date: Mon, 12 Sep 2011 11:47:53 -0400
>Subject: [PATCH] NFS: Fix a typo in nfs_flush_multi
>
>Fix a typo which causes an Oops in the RPC layer, when using wsize < 4k.
>
>Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>---
> fs/nfs/write.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/fs/nfs/write.c b/fs/nfs/write.c
>index b39b37f..c9bd2a6 100644
>--- a/fs/nfs/write.c
>+++ b/fs/nfs/write.c
>@@ -958,7 +958,7 @@ static int nfs_flush_multi(struct
nfs_pageio_descriptor
>*desc, struct list_head
> 		if (!data)
> 			goto out_bad;
> 		data->pagevec[0] = page;
>-		nfs_write_rpcsetup(req, data, wsize, offset,
desc->pg_ioflags);
>+		nfs_write_rpcsetup(req, data, len, offset,
desc->pg_ioflags);
> 		list_add(&data->list, res);
> 		requests++;
> 		nbytes -= len;
>--
>1.7.6
>
>
>
>--
>Trond Myklebust
>Linux NFS client maintainer
>
>NetApp
>Trond.Myklebust@netapp.com
>www.netapp.com

  reply	other threads:[~2011-09-13  6:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09 13:10 Regression seen when HIGHMEM enabled with NFS on 3.1rc4 kernel R, Sricharan
2011-09-09 18:51 ` Trond Myklebust
2011-09-12  6:16   ` Sricharan R
2011-09-12 14:41     ` Trond Myklebust
2011-09-12 15:54       ` Trond Myklebust
2011-09-13  6:41         ` Sricharan R [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-09 12:42 Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c29a4c977b98cf95ef8c7f69e094896@mail.gmail.com \
    --to=r.sricharan@ti.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).