From: Jeff Layton <jlayton@kernel.org>
To: Olga Kornievskaia <okorniev@redhat.com>, chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org, neilb@brown.name, Dai.Ngo@oracle.com,
tom@talpey.com
Subject: Re: [PATCH v3 0/2] nfsd update mtime/ctime on CLONE/COPY with delegated attritutes
Date: Thu, 09 Apr 2026 12:56:31 -0400 [thread overview]
Message-ID: <7d2cb2814a6090d240cc4e48d6428a40b332e10f.camel@kernel.org> (raw)
In-Reply-To: <20260409164316.19748-1-okorniev@redhat.com>
On Thu, 2026-04-09 at 12:43 -0400, Olga Kornievskaia wrote:
> generic/407 is failing in presence of delegated attributes and this patch series
> explores the solution where the CLONE compound returns updated mtime/ctime
> in the GETATTR op in the compound.
>
> Both CLONE and COPY need to update destination file mtime/ctime
> (in presence of delegated timestamp) when file was modified.
>
> v3 changes:
> --- Consolidated synchronous and asynchronous COPY patches into single
> patch.
> patch1: pulled out notify_change() code from nfsd4_finalize_deleg_timestamps as
> it's shared with nfsd_update_cmtime_attr and both paths log an error if
> notify_change() fails
> patch2: dentry can be pulled from copy->nf_dst->nf_file.fh_path.dentry and
> no longer requires additional tracking.
>
> Olga Kornievskaia (2):
> nfsd: update mtime/ctime on CLONE in presense of delegated attributes
> nfsd: update mtime/ctime on COPY in presence of delegated attributes
>
> fs/nfsd/nfs4proc.c | 30 +++++++++++++++++++++++++++++-
> fs/nfsd/nfs4state.c | 14 +-------------
> fs/nfsd/state.h | 16 ++++++++++++++++
> 3 files changed, 46 insertions(+), 14 deletions(-)
Nice work.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-04-09 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 16:43 [PATCH v3 0/2] nfsd update mtime/ctime on CLONE/COPY with delegated attritutes Olga Kornievskaia
2026-04-09 16:43 ` [PATCH v3 1/2] nfsd: update mtime/ctime on CLONE in presense of delegated attributes Olga Kornievskaia
2026-04-09 19:21 ` Chuck Lever
2026-04-09 16:43 ` [PATCH v3 2/2] nfsd: update mtime/ctime on COPY in presence " Olga Kornievskaia
2026-04-09 18:37 ` Chuck Lever
2026-04-09 18:50 ` Olga Kornievskaia
2026-04-09 16:56 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d2cb2814a6090d240cc4e48d6428a40b332e10f.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox