Linux NFS development
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: bfields <bfields@fieldses.org>
Cc: linux-nfs <linux-nfs@vger.kernel.org>,
	luis turcitu <luis.turcitu@appsbroker.com>,
	chris chilvers <chris.chilvers@appsbroker.com>,
	david young <david.young@appsbroker.com>,
	Daire Byrne <daire@dneg.com>,
	david oberhollenzer <david.oberhollenzer@sigma-star.at>,
	david <david@sigma-star.at>,
	goliath@sigma-star.at,
	trond myklebust <trond.myklebust@hammerspace.com>,
	anna schumaker <anna.schumaker@netapp.com>
Subject: Re: [RFC PATCH] mountd: export: Deal with NFS filesystems
Date: Mon, 31 Jan 2022 18:15:41 +0100 (CET)	[thread overview]
Message-ID: <8290532.5517.1643649341941.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20220131170125.GB30119@fieldses.org>

----- Ursprüngliche Mail -----
> Von: "bfields" <bfields@fieldses.org>
>> Using /proc/fs/nfsfs/volumes it is possible to find the NFS fsid
>> from the backend and use it as seed for mountd's UUID mechanism.
> 
> Sorry, I haven't checked--what is that number, really?  It's probably
> not the fsid returned from the server, as that wouldn't be guaranteed
> unique across multiple servers.  But that means it's probably generated
> in a way that doesn't guarantee it's stable across reboots.  And we need
> filehandles to work across reboots.

Unless I badly misunderstood the code it comes from fs/nfs/client.c's
nfs_create_server() where the NFS client fetches NFS_ATTR_FATTR via getattr().
So it should be unique:
https://datatracker.ietf.org/doc/html/rfc7530#section-5.8.1.9

Thanks,
//richard

  reply	other threads:[~2022-01-31 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 10:43 [RFC PATCH] mountd: export: Deal with NFS filesystems Richard Weinberger
2022-01-31 17:01 ` J. Bruce Fields
2022-01-31 17:15   ` Richard Weinberger [this message]
2022-01-31 20:37     ` bfields
2022-01-31 21:57       ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8290532.5517.1643649341941.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=chris.chilvers@appsbroker.com \
    --cc=daire@dneg.com \
    --cc=david.oberhollenzer@sigma-star.at \
    --cc=david.young@appsbroker.com \
    --cc=david@sigma-star.at \
    --cc=goliath@sigma-star.at \
    --cc=linux-nfs@vger.kernel.org \
    --cc=luis.turcitu@appsbroker.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox