Linux NFS development
 help / color / mirror / Atom feed
From: Frank Sorenson <sorenson@redhat.com>
To: linux-nfs <linux-nfs@vger.kernel.org>, linux-fsdevel@vger.kernel.org
Subject: [PATCH] NFS: change sign of nfs_fh length
Date: Tue, 23 Oct 2018 10:34:57 -0500	[thread overview]
Message-ID: <85517ec3-e3d4-1bf3-8eea-cb274face1a7@redhat.com> (raw)


The filehandle has a length which is defined as a 32-bit
"unsigned integer".  Change sign of the length appropriately.

Signed-off-by: Frank Sorenson <sorenson@redhat.com>
---
 fs/nfs/nfs4xdr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index b7bde12d8cd5..2fc8f6fa25e4 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -3516,7 +3516,7 @@ static int decode_attr_exclcreat_supported(struct
xdr_stream *xdr,
 static int decode_attr_filehandle(struct xdr_stream *xdr, uint32_t
*bitmap, struct nfs_fh *fh)
 {
 	__be32 *p;
-	int len;
+	u32 len;

 	if (fh != NULL)
 		memset(fh, 0, sizeof(*fh));
-- 
2.13.6


             reply	other threads:[~2018-10-23 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 15:34 Frank Sorenson [this message]
2018-10-23 15:40 ` [PATCH] NFS: change sign of nfs_fh length Matthew Wilcox
2018-10-23 16:09   ` Trond Myklebust
2018-10-23 17:10     ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85517ec3-e3d4-1bf3-8eea-cb274face1a7@redhat.com \
    --to=sorenson@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox