From: NeilBrown <neilb@suse.com>
To: Bennett Amodio <bamodio@purestorage.com>, linux-nfs@vger.kernel.org
Cc: anna.schumaker@netapp.com, trond.myklebust@primarydata.com,
Igor Ostrovsky <igor@purestorage.com>,
Vas Chellappa <vas@purestorage.com>,
Jui-Yu Chang <juchang@purestorage.com>
Subject: Re: [RFC v3 2/2] SUNRPC: Mask XIDs to prevent replay cache collision
Date: Thu, 17 Aug 2017 13:33:49 +1000 [thread overview]
Message-ID: <87mv6yna02.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAKk7tABaTxA102tUHEuYyC8rtbNDjzHX6MdVcCkTy_26yfVkvA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Tue, Aug 15 2017, Bennett Amodio wrote:
>
> for (i = 0; i < args->nconnect - 1; i++) {
> + xprtargs.transport_id += 1;
> if (rpc_clnt_add_xprt(clnt, &xprtargs, NULL, NULL) < 0)
> break;
> }
hi,
this is a tiny point, but I think this code would look nicer as
for (i = 1; i < args->nconnect; i++) {
xprtargs.transport_id = i;
if (rpc_clnt_add_xprt(clnt, &xprtargs, NULL, NULL) < 0)
break;
}
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-08-17 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 0:51 [RFC v3 2/2] SUNRPC: Mask XIDs to prevent replay cache collision Bennett Amodio
2017-08-17 3:23 ` NeilBrown
2017-08-17 3:33 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv6yna02.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=anna.schumaker@netapp.com \
--cc=bamodio@purestorage.com \
--cc=igor@purestorage.com \
--cc=juchang@purestorage.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
--cc=vas@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).