linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@redhat.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Question about nfsdcltrack --storagedir
Date: Fri, 11 Nov 2016 09:32:07 +1100	[thread overview]
Message-ID: <87oa1nklug.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <8B417571-FAA9-4793-AE5F-F71BCDF7ADD5@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Fri, Nov 11 2016, Chuck Lever wrote:

>> 
>> No objection here, especially if we make it so that we have existing
>> behavior when there is no config file. nfs-utils even has some config
>> file parsing routines now in support/nfs that should be sufficient.
>
> Just a general thought:
>
> It's fine to store the configuration data under /etc, but for new
> administrative interfaces, please create a command line UI which
> is used to edit said configuration data. This makes it much easier
> for users to script administrative changes, to build GUIs around,
> and for our Q/A teams to construct automated tests.

If that is an important concern (and I don't disagree) then I would
suggest dropping the idea of a config file with sections and just have a
file with simple (case sensitive) "name=value" assignments.  Then sed
can be used to modify the file.

Or.... just use git to modify the config file.

  sudo git config --file /etc/idmapd.conf mapping.nobody-user neilb

did what I expected it to do :-)

I would lean towards a flat config file myself, but nfs-utils already
has code for structured config files, and that code ignores settings
before the first section.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

  reply	other threads:[~2016-11-10 22:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  3:46 Question about nfsdcltrack --storagedir NeilBrown
2016-11-09 11:57 ` Jeff Layton
2016-11-09 23:54   ` NeilBrown
2016-11-10  0:55     ` Jeff Layton
2016-11-10  4:58       ` [PATCH/RFC nfs-utils] nfsdcltrack: read configuration from a file NeilBrown
2016-11-10 15:00         ` Jeff Layton
2016-11-10 22:17           ` NeilBrown
2016-11-13 12:40             ` Jeff Layton
2016-11-15 16:52               ` Steve Dickson
2016-11-15 17:07         ` Steve Dickson
2016-11-16 18:22         ` Steve Dickson
2016-11-10 14:55       ` Question about nfsdcltrack --storagedir Chuck Lever
2016-11-10 22:32         ` NeilBrown [this message]
2016-11-11 16:19           ` Chuck Lever
2016-11-16  4:00             ` NeilBrown
2016-11-10 16:35     ` J. Bruce Fields
2016-11-10 22:35       ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa1nklug.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).