From: NeilBrown <neilb@suse.com>
To: Justin Mitchell <jumitche@redhat.com>,
"linux-nfs\@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH 3/3] nfs.conf tidy ups
Date: Wed, 07 Jun 2017 13:11:13 +1000 [thread overview]
Message-ID: <87shjcbige.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1495468363.4169.13.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Mon, May 22 2017, Justin Mitchell wrote:
> Remove the line length parameter and associated code which
> led to buffer overruns in the line parsing code.
> Also drops the undocumented 'include' directive.
No, please don't drop the "include" directive.
It was there for a reason. See commit be38fd8b8011c6bd.
Yes, it should be documented. I'm happy to provide documentation. But
please do remove things without first understanding why they are there.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-06-07 3:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:52 [PATCH 3/3] nfs.conf tidy ups Justin Mitchell
2017-06-01 15:07 ` Steve Dickson
2017-06-02 8:57 ` Justin Mitchell
2017-06-06 14:36 ` Steve Dickson
2017-06-07 3:11 ` NeilBrown [this message]
2017-06-07 16:02 ` J. Bruce Fields
2017-06-08 20:35 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shjcbige.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=jumitche@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).