From: Nix <nix@esperi.org.uk>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: 2.6.34rc4 NFS writeback regression (bisected): client often fails to delete things it just created
Date: Sun, 18 Apr 2010 20:27:19 +0100 [thread overview]
Message-ID: <87vdboa7e0.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <1271618484.8049.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> (Trond Myklebust's message of "Sun, 18 Apr 2010 15:21:24 -0400")
On 18 Apr 2010, Trond Myklebust verbalised:
> On Sat, 2010-04-17 at 20:43 +0100, Nix wrote:
>> I suspect that unlink()ing a not otherwise open file for which writeback
>> is still underway is causing the files to be sillyrenamed because
>> writeback is holding them open. If writeback is the only user, they
>> should surely not be held open: nobody cares what their contents are,
>> and a lot of code depends on rm -r of directories containing recently-
>> written-but-still-closed files succeeding.
>
> Did you test with commit b80c3cb628f0ebc241b02e38dd028969fb8026a2 (NFS:
> Ensure that writeback_single_inode() calls write_inode() when syncing)?
> That fixed the above problem on my setup.
tip-of-tree includes that commit, and it's still happening for me there.
(Just verified again.)
(The exported filesystem is coming from a box running 2.6.33 atop ext4,
in case it matters.)
next prev parent reply other threads:[~2010-04-18 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 19:43 2.6.34rc4 NFS writeback regression (bisected): client often fails to delete things it just created Nix
[not found] ` <87tyr9dfvv.fsf-AdTWujXS48Mg67Zj9sPl2A@public.gmane.org>
2010-04-18 19:21 ` Trond Myklebust
[not found] ` <1271618484.8049.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-18 19:27 ` Nix [this message]
[not found] ` <87vdboa7e0.fsf-AdTWujXS48Mg67Zj9sPl2A@public.gmane.org>
2010-04-18 19:59 ` Trond Myklebust
[not found] ` <1271620750.8049.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-18 20:03 ` Nix
[not found] ` <87mxx0a5pc.fsf-AdTWujXS48Mg67Zj9sPl2A@public.gmane.org>
2010-04-18 20:13 ` Trond Myklebust
[not found] ` <1271621624.8049.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-18 21:09 ` Nix
2010-04-19 13:10 ` Trond Myklebust
[not found] ` <1271682635.13653.40.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-19 18:54 ` Nix
2010-04-20 12:37 ` Trond Myklebust
[not found] ` <1271767064.25129.84.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-04-20 22:19 ` Nix
2010-04-21 22:13 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdboa7e0.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox