From: NeilBrown <neilb@suse.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH] nfsstats: fix some exit codes.
Date: Thu, 05 Jan 2017 08:32:46 +1100 [thread overview]
Message-ID: <87zij6lddt.fsf@notabene.neil.brown.name> (raw)
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
"nfsstat -m" always exits with "1" (unless there is an error opening
/proc/mounts). It should exist "0".
Also, a few usage errors cause an exit of "255" when it should probably
be "1".
Signed-off-by: NeilBrown <neilb@suse.com>
---
utils/nfsstat/nfsstat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
index 8376347d5af4..eddbe9a14f25 100644
--- a/utils/nfsstat/nfsstat.c
+++ b/utils/nfsstat/nfsstat.c
@@ -389,7 +389,7 @@ main(int argc, char **argv)
switch (c) {
case 'a':
fprintf(stderr, "nfsstat: nfs acls are not yet supported.\n");
- return -1;
+ return 1;
case 'c':
opt_clt = 1;
break;
@@ -455,7 +455,7 @@ main(int argc, char **argv)
"not yet supported\n");
return 2;
case 'm':
- return mounts(MOUNTSFILE);
+ return ! mounts(MOUNTSFILE);
case '\1':
usage(progname);
return 0;
@@ -464,7 +464,7 @@ main(int argc, char **argv)
return 0;
default:
printf("Try `%s --help' for more information.\n", progname);
- return -1;
+ return 1;
}
}
--
2.11.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2017-01-04 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 21:32 NeilBrown [this message]
2017-01-11 16:09 ` [nfs-utils PATCH] nfsstats: fix some exit codes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zij6lddt.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).