Re: [PATCH 2/4] exportfs: split out the ops for layout-based block device access

["Chuck Lever" <cel@kernel.org>]

On Tue, Mar 31, 2026, at 11:33 AM, Christoph Hellwig wrote:
> The support to grant layouts for direct block device access works
> at a very different layer than the rest of exports.  Split the methods
> for it into a separate struct, and move that into a separate header
> to better split things out.  The pointer to the new operation vector
> is kept in export_operations to avoid bloating the super_block.

> diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
> index 221e55887a2a..a52978f6fb76 100644
> --- a/fs/xfs/xfs_pnfs.c
> +++ b/fs/xfs/xfs_pnfs.c
> @@ -332,3 +332,9 @@ xfs_fs_commit_blocks(
>  	xfs_iunlock(ip, XFS_IOLOCK_EXCL);
>  	return error;
>  }
> +
> +struct exportfs_block_ops xfs_export_block_ops = {
> +	.get_uuid		= xfs_fs_get_uuid,
> +	.map_blocks		= xfs_fs_map_blocks,
> +	.commit_blocks		= xfs_fs_commit_blocks,
> +};

Should xfs_export_block_ops be declared "const" ?


-- 
Chuck Lever