Re: [PATCH pynfs 0/7] nfs4.1: add some basic directory delegation tests

[Jeff Layton <jlayton@kernel.org>]

On Tue, 2025-09-30 at 09:48 -0400, Chuck Lever wrote:
> On 9/30/25 7:37 AM, Jeff Layton wrote:
> > Add basic support for testing both GET_DIR_DELEGATION operations and
> > CB_NOTIFY.
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > Jeff Layton (7):
> >       nfs4.1: add proposed NOTIFY4_GFLAG_EXTEND flag
> >       pynfs: add a getfh() to the end of create_obj() compound
> >       server41tests: add a basic GET_DIR_DELEGATION test
> >       server41tests: add a test for duplicate GET_DIR_DELEGATION requests
> >       server41tests: add a test for removal from dir with dir delegation
> >       server41tests: add a test for diretory add notifications
> >       server41tests: add test for rename event notifications
> > 
> >  nfs4.1/nfs4client.py                 |   6 +
> >  nfs4.1/server41tests/__init__.py     |   1 +
> >  nfs4.1/server41tests/environment.py  |   2 +-
> >  nfs4.1/server41tests/st_dir_deleg.py | 221 +++++++++++++++++++++++++++++++++++
> >  nfs4.1/xdrdef/nfs4.x                 |   3 +-
> >  5 files changed, 231 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 3c14d9e3ad12272ab2f6092c85bb28ab03951484
> > change-id: 20250930-dir-deleg-4ae7364fb398
> > 
> > Best regards,
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 
> But one question: should these new tests not be in the "all" group?
> Seems like most NFS server implementations won't support directory
> delegations.
> 

I had meant to remove that group before posting and then forgot about
it. That is a good point though...

Ideally what would best would be to try and run it, and just make it a
non-fatal error if the initial GET_DIR_DELEGATION fails? Maybe just
make it pass_warn() in that case?

I like that idea better than hiding this away where we forget to run
it. I'll see what I can put together.

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>