From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E38672264AD for ; Mon, 27 Oct 2025 13:25:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571552; cv=none; b=r3VMCAlf/mYZEgZU0EDf4c3f/Q6JZOm8mX8ZJIVeJNPAJ+LRR5+QWOy20JBz8dbK25D+63ev2iZqBzXGtZEhNizSOotM7XD7/JJkC2CTSRkWDI9Xrw5yRztqVID+kJP7HCfMf6+Jwacdphmt+g5TuK0VervawR9R8e8xnW4jfnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761571552; c=relaxed/simple; bh=MJxIVqyABXEBO6zURfmsJW0BIzniuy6GFN4s5C/SszU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DeNZ5y/cF8tC/PLKHyvUfZkUdMHdnsvELqSMQFnx3nM8nGMYMtrPkslvv0hsho+aw2f2TsiucG4W/8y8HDl4heyxIMWAsA99/jBENoQFjD9em1bdnWCu56NDWLNrWatmGOJdrKDsmzXPjtXsu77+bEulh9MXXGgndzn/kA6BuYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a5WZCB07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a5WZCB07" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6684C113D0; Mon, 27 Oct 2025 13:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761571551; bh=MJxIVqyABXEBO6zURfmsJW0BIzniuy6GFN4s5C/SszU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=a5WZCB07o4J+WOhrEmnqOheYpwXScyH+pkhetfxG0TGMTgX9ldK+E3tnq+bVNaa65 RT68i8immr3S5Hke6d1HjVdGH4d8EqjtX1rZF8C3Ljf8a2I7aWrzheelFcV2enUPCJ 1kSJn/s3qdYlhr2whuyUnIWRXf4iawojNGFGSkKXrMkKjZ+1pvJU1nwRC3vq29SzD+ Hf8ILovgFUOmBnfsydgNWRRUptWR7FjGcyM5R+cyn6ClEFVUqJMydkNZtKu991R7Li bNFTfrCxUgHvmYmeDf+WPHVd0USUq3tv1saYN0jyOJ9L+i13qm5a9sSYK8ApqKlNPz O7LqphZK8ZSSQ== Message-ID: <8aab9213-b334-4c87-8fa4-efabb5daeeb3@kernel.org> Date: Mon, 27 Oct 2025 09:25:49 -0400 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 08/14] NFSD: Remove alignment size checking To: Christoph Hellwig Cc: NeilBrown , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, Chuck Lever , Christoph Hellwig References: <20251024144306.35652-1-cel@kernel.org> <20251024144306.35652-9-cel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/27/25 4:09 AM, Christoph Hellwig wrote: > On Fri, Oct 24, 2025 at 10:43:00AM -0400, Chuck Lever wrote: >> From: Chuck Lever >> >> The current set of in-tree file systems do not support alignments >> larger than a PAGE, so this check is unnecessary. > > XFS does, although your won't find production hardware with > 4k > blocks as far as I can tell. The reason to drop this check was > to not arbitrarily exclude them for no reason. IIRC there is a reason: NFSD_IO_DIRECT writes won't be able to align on larger than a page (for the memory buffers). But perhaps the alignment constraint that was removed applied only to the file offset. -- Chuck Lever