Re: [nfs-utils PATCH] Rename CONFIG_NFSV41 to CONFIG_BLKMAPD and disable by default

[Steve Dickson <steved@redhat.com>]

On 1/14/26 9:54 AM, Scott Mayhew wrote:
> pNFS block layout is deprecated in favor of pNFS SCSI layout, which
> doesn't require the use of blkmapd.
> 
> Since CONFIG_NFSV41 (enabled by default, but can be disabled via
> --disable-nfsv41) is only used to enable blkmapd, let's rename it to
> CONFIG_BLKMAPD and change the default to disabled.
> 
> Distributions that wish to continue to include blkmapd can do so by
> adding --enable-blkmapd to their configure script invocation.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... (tag: nfs-utils-2-8-5-rc2)

steved.

> ---
>   configure.ac        | 22 +++++++++++-----------
>   systemd/Makefile.am |  2 +-
>   utils/Makefile.am   |  2 +-
>   3 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6da23915..bcbf0d69 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -85,22 +85,22 @@ AC_ARG_ENABLE(nfsv4,
>   	AC_SUBST(enable_nfsv4)
>   	AM_CONDITIONAL(CONFIG_NFSV4, [test "$enable_nfsv4" = "yes"])
>   
> -AC_ARG_ENABLE(nfsv41,
> -	[AS_HELP_STRING([--disable-nfsv41],[disable support for NFSv41 @<:@default=no@:>@])],
> -	enable_nfsv41=$enableval,
> -	enable_nfsv41=yes)
> -	if test "$enable_nfsv41" = yes; then
> +AC_ARG_ENABLE(blkmapd,
> +	[AS_HELP_STRING([--enable-blkmapd],[enable support for blkmapd @<:@default=no@:>@])],
> +	enable_blkmapd=$enableval,
> +	enable_blkmapd=no)
> +	if test "$enable_blkmapd" = yes; then
>   		if test "$enable_nfsv4" != yes; then
> -			AC_MSG_WARN([NFS v4 is not enabled. Disabling NFS v4.1])
> -			enable_nfsv41=no
> +			AC_MSG_WARN([NFS v4 is not enabled. Disabling blkmapd.])
> +			enable_blkmapd=no
>   		fi
>   		BLKMAPD=blkmapd
>   	else
> -		enable_nfsv41=
> +		enable_blkmapd=
>   		BLKMAPD=
>   	fi
> -	AC_SUBST(enable_nfsv41)
> -	AM_CONDITIONAL(CONFIG_NFSV41, [test "$enable_nfsv41" = "yes"])
> +	AC_SUBST(enable_blkmapd)
> +	AM_CONDITIONAL(CONFIG_BLKMAPD, [test "$enable_blkmapd" = "yes"])
>   
>   AC_ARG_ENABLE(gss,
>   	[AS_HELP_STRING([--disable-gss],[disable client support for rpcsec_gss @<:@default=no@:>@])],
> @@ -398,7 +398,7 @@ else
>     enable_nfsdcltrack="no"
>   fi
>   
> -if test "$enable_nfsv41" = yes; then
> +if test "$enable_blkmapd" = yes; then
>     AC_CHECK_LIB([devmapper], [dm_task_create], [LIBDEVMAPPER="-ldevmapper"], AC_MSG_ERROR([libdevmapper needed]))
>     AC_CHECK_HEADER(libdevmapper.h, , AC_MSG_ERROR([Cannot find devmapper header file libdevmapper.h]))
>     AC_CHECK_HEADER(sys/inotify.h, , AC_MSG_ERROR([Cannot find header file sys/inotify.h]))
> diff --git a/systemd/Makefile.am b/systemd/Makefile.am
> index 5e481421..9cc940dc 100644
> --- a/systemd/Makefile.am
> +++ b/systemd/Makefile.am
> @@ -32,7 +32,7 @@ unit_files += \
>       nfsv4-server.service
>   endif
>   
> -if CONFIG_NFSV41
> +if CONFIG_BLKMAPD
>   unit_files += \
>       nfs-blkmap.service
>   endif
> diff --git a/utils/Makefile.am b/utils/Makefile.am
> index e5cb81e7..bfa12081 100644
> --- a/utils/Makefile.am
> +++ b/utils/Makefile.am
> @@ -11,7 +11,7 @@ if CONFIG_NFSV4SERVER
>   OPTDIRS += exportd
>   endif
>   
> -if CONFIG_NFSV41
> +if CONFIG_BLKMAPD
>   OPTDIRS += blkmapd
>   endif
>