From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EFD535968 for ; Mon, 20 Jan 2025 07:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737357984; cv=none; b=U5aosoIiqsQLBpxIlvRR04wY7jg3adNgvHTbHry20eExJuUHvRhz5LawKVsRO2uBmzjzr4qT/boY1ohfU6ARKCVfQcrczrOcbkpAlDy16uLYSNEFfeG+JkB9U+MIEHw9MJ+9C28ohwM6MEhhei4N/wT+uDvOzB5RQki0Pc3m3J0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737357984; c=relaxed/simple; bh=NxrX+d+0FJm7uBeq9Nx21TS64oGqyY66R0wlt6V+wKo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=ZuaDTzdt+HzZtJADDG3IkSKZ7MrPOMlxa8SIJ0A99hfRM8E9PVCAkjgzVOz8976ycypTQYMn5NBjlHlUxndg5AAl+ufajLNzeTAVVnjiYiHmQ1KuxEi3bNw2AB5/fXfZRfxJSuhFxVEjmWSa0ZgYx8AWuouijtJ9doRmoz144L8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x34V8iRb; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x34V8iRb" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3863c36a731so3551717f8f.1 for ; Sun, 19 Jan 2025 23:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737357980; x=1737962780; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5NHSYRaPcEvsDMUedKc48IMCuOjSeAPTyPR3Rlj7XW8=; b=x34V8iRbrQwizfwUyRIpggAOXBF1v2/rAwwsS+I1DFFzFMFYdDEvs9CpzAxykjLAfm NeKh4CTUP9sFUrG9nwUW39qBTw5141vTO16J+3t6rVI/aJoZ2DgtctTSUgZNnr8rd98R KOik9dKDC+frIY99I93CAvqxlqm6GTnSI9K/B/15kUY5FmGPh6zHBZrpJgT0POJ0pn9Q iGbqVNhjGpWrUR0JSTwiZdG2nOxCVqYY3nFED49ZjjMgRlR+MgBCELx6GYP5w0DRTEQP B3IkRTJYfAD0UQnt6CS9AJPm1qeX/6y7y/9HcYUR78A/Sy/e5m1q4pBZ5b6b18BpWizx cePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737357980; x=1737962780; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5NHSYRaPcEvsDMUedKc48IMCuOjSeAPTyPR3Rlj7XW8=; b=llyxhhtzBTWMkdn9IGjxEZKRRyXfPdUZnBU2eNawTa/Jup5EZSk31WgQv/lXWzrNfB CD7ejm9gWRkMPuCRdtSZvVDgnMUQ1uDOQqYxT+5dE5TJR5XAJ65XPiz/gOHXm4udWpWc BYObG80dpyHBeU6qvD14s+TbX33Cz/pGqlpNO/+d+bGo1zCprNnqlxQC1F7m5DFSP2n6 xBTzL8Az7hhJmkr/+3iX9VtXv4wHXnMcXpkXMGXJHn3LU5bg6WpvK81vjSM39rx7X7Aw mHQdOWT/frV8B50bCy2oUWBSKQ5jTusvrr16qJfavceSCStCMvzKKgWu5B2rg6NAhEU8 hIkQ== X-Forwarded-Encrypted: i=1; AJvYcCUlGXaWguHlncICWPbr9ba5DkTxmFyMlR+pRt0rS0Sl6T7Ihv/6NyVtnIiLhlMv4WAIcj/3DG9IoHE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmg6lxHW+jfBYD3heOKPbJkVJuPmRNrWHWXPlaj6rko3TtvBjr 3NZFpv6LtUXfTvuFSlYD3eTYmhHarhsNTD9xTFag+i7Smdvnk0CkEbJcmTq0z2U= X-Gm-Gg: ASbGncu/LRe4D6GTt10/UNkVSS5FgZwbAJjsM/43tYYG3+Qn8u4jP830zxfKGk7H7TD Pcq+ZCBdl+QTq+rk/LVsrBAJyhzuSgtCJ5j9DzZDrMtwfxIsR3FjWFUtB8gD/rxLMKYvz3Ni9K9 rWOsgW3gSvAO2cjEz9LqqqkcU6JWn80XsliRYFZ2Mmy124m/WH7pa+AvvKK+KXjXfI4wxq0H1Xb WR1zFxaRFA/Og6stcJjZ0a1QAsmVBoMws+aIO2SIjtUZoVROY/dYmYE8RhneSqeH0EKmjFan3w= X-Google-Smtp-Source: AGHT+IFOQ4n65F/+nmAYHyUgPJBiA7g98gePoOtSSWjEuNIrNEx2PNFqoffpLVNeYjrRxM2H4+qstg== X-Received: by 2002:a05:6000:1a8b:b0:385:e9ba:acda with SMTP id ffacd0b85a97d-38bf56781a4mr10706340f8f.2.1737357980411; Sun, 19 Jan 2025 23:26:20 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3278088sm9521175f8f.73.2025.01.19.23.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2025 23:26:20 -0800 (PST) Date: Mon, 20 Jan 2025 10:26:16 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Anna Schumaker , linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, anna@kernel.org Subject: Re: [PATCH 3/3] sunrpc: Add a sysfs file for adding a new xprt Message-ID: <8d0e2cd9-e47e-48f5-ae73-0e19d08ae807@stanley.mountain> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250108213632.260498-4-anna@kernel.org> Hi Anna, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anna-Schumaker/NFS-Add-implid-to-sysfs/20250109-053732 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next patch link: https://lore.kernel.org/r/20250108213632.260498-4-anna%40kernel.org patch subject: [PATCH 3/3] sunrpc: Add a sysfs file for adding a new xprt config: x86_64-randconfig-r073-20250119 (https://download.01.org/0day-ci/archive/20250120/202501200000.40Rg2rc6-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202501200000.40Rg2rc6-lkp@intel.com/ New smatch warnings: net/sunrpc/sysfs.c:288 rpc_sysfs_xprt_switch_add_xprt_store() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +288 net/sunrpc/sysfs.c 2b155d9a088aee Anna Schumaker 2025-01-08 260 static ssize_t rpc_sysfs_xprt_switch_add_xprt_store(struct kobject *kobj, 2b155d9a088aee Anna Schumaker 2025-01-08 261 struct kobj_attribute *attr, 2b155d9a088aee Anna Schumaker 2025-01-08 262 const char *buf, size_t count) 2b155d9a088aee Anna Schumaker 2025-01-08 263 { 2b155d9a088aee Anna Schumaker 2025-01-08 264 struct rpc_xprt_switch *xprt_switch = 2b155d9a088aee Anna Schumaker 2025-01-08 265 rpc_sysfs_xprt_switch_kobj_get_xprt(kobj); 2b155d9a088aee Anna Schumaker 2025-01-08 266 struct xprt_create xprt_create_args; 2b155d9a088aee Anna Schumaker 2025-01-08 267 struct rpc_xprt *xprt, *new; 2b155d9a088aee Anna Schumaker 2025-01-08 268 2b155d9a088aee Anna Schumaker 2025-01-08 269 if (!xprt_switch) 2b155d9a088aee Anna Schumaker 2025-01-08 270 return 0; 2b155d9a088aee Anna Schumaker 2025-01-08 271 2b155d9a088aee Anna Schumaker 2025-01-08 272 xprt = rpc_xprt_switch_get_main_xprt(xprt_switch); 2b155d9a088aee Anna Schumaker 2025-01-08 273 if (!xprt) 2b155d9a088aee Anna Schumaker 2025-01-08 274 goto out; 2b155d9a088aee Anna Schumaker 2025-01-08 275 2b155d9a088aee Anna Schumaker 2025-01-08 276 xprt_create_args.ident = xprt->xprt_class->ident; 2b155d9a088aee Anna Schumaker 2025-01-08 277 xprt_create_args.net = xprt->xprt_net; 2b155d9a088aee Anna Schumaker 2025-01-08 278 xprt_create_args.dstaddr = (struct sockaddr *)&xprt->addr; 2b155d9a088aee Anna Schumaker 2025-01-08 279 xprt_create_args.addrlen = xprt->addrlen; 2b155d9a088aee Anna Schumaker 2025-01-08 280 xprt_create_args.servername = xprt->servername; 2b155d9a088aee Anna Schumaker 2025-01-08 281 xprt_create_args.bc_xprt = xprt->bc_xprt; 2b155d9a088aee Anna Schumaker 2025-01-08 282 xprt_create_args.xprtsec = xprt->xprtsec; 2b155d9a088aee Anna Schumaker 2025-01-08 283 xprt_create_args.connect_timeout = xprt->connect_timeout; 2b155d9a088aee Anna Schumaker 2025-01-08 284 xprt_create_args.reconnect_timeout = xprt->max_reconnect_timeout; 2b155d9a088aee Anna Schumaker 2025-01-08 285 2b155d9a088aee Anna Schumaker 2025-01-08 286 new = xprt_create_transport(&xprt_create_args); 2b155d9a088aee Anna Schumaker 2025-01-08 287 if (IS_ERR_OR_NULL(new)) { This should just be if (IS_ERR(new)) {, otherwise we end up with a nonsense debate about whether impossible NULL returns should be handled as a error or a success. 2b155d9a088aee Anna Schumaker 2025-01-08 @288 count = PTR_ERR(new); 2b155d9a088aee Anna Schumaker 2025-01-08 289 goto out_put_xprt; 2b155d9a088aee Anna Schumaker 2025-01-08 290 } 2b155d9a088aee Anna Schumaker 2025-01-08 291 2b155d9a088aee Anna Schumaker 2025-01-08 292 rpc_xprt_switch_add_xprt(xprt_switch, new); 2b155d9a088aee Anna Schumaker 2025-01-08 293 xprt_put(new); 2b155d9a088aee Anna Schumaker 2025-01-08 294 2b155d9a088aee Anna Schumaker 2025-01-08 295 out_put_xprt: 2b155d9a088aee Anna Schumaker 2025-01-08 296 xprt_put(xprt); 2b155d9a088aee Anna Schumaker 2025-01-08 297 out: 2b155d9a088aee Anna Schumaker 2025-01-08 298 xprt_switch_put(xprt_switch); 2b155d9a088aee Anna Schumaker 2025-01-08 299 return count; 2b155d9a088aee Anna Schumaker 2025-01-08 300 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki