Re: [PATCH v1 1/2] NFSD: Replace NFS3_ACCESS_FULL in nfsd4_access()

[Jeff Layton <jlayton@kernel.org>]

On Mon, 2026-08-10 at 10:18 -0400, Chuck Lever wrote:
> Clean up: Remove an NFSv3 constant (NFS3_ACCESS_FULL) used inside an
> NFSv4 code path.
> 
> After this patch is applied, the nfs3.h header is no longer an
> implicit dependency of nfs4proc.c for this value. The definition
> itself stays in nfs3.h to avoid a kernel-user space API regression.
> 
> Signed-off-by: Chuck Lever <cel@kernel.org>
> ---
>  fs/nfsd/nfs4proc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 03c32db618cd..a2bea8947ef5 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -842,7 +842,9 @@ nfsd4_access(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>  	struct nfsd4_access *access = &u->access;
>  	u32 access_full;
>  
> -	access_full = NFS3_ACCESS_FULL;
> +	access_full = NFS4_ACCESS_READ | NFS4_ACCESS_LOOKUP |
> +		      NFS4_ACCESS_MODIFY | NFS4_ACCESS_EXTEND |
> +		      NFS4_ACCESS_DELETE | NFS4_ACCESS_EXECUTE;
>  	if (cstate->minorversion >= 2)
>  		access_full |= NFS4_ACCESS_XALIST | NFS4_ACCESS_XAREAD |
>  			       NFS4_ACCESS_XAWRITE;

Reviewed-by: Jeff Layton <jlayton@kernel.org>