Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	Alexander Viro	 <viro@zeniv.linux.org.uk>,
	Jan Kara <jack@suse.cz>, Thomas Haynes	 <loghyr@gmail.com>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] fs/nfsd: accept a backdated timestamp from a delegation holder
Date: Fri, 04 Sep 2026 07:10:11 -0400	[thread overview]
Message-ID: <932876f491f436d622f3c365cfe6fda1225833c5.camel@kernel.org> (raw)
In-Reply-To: <20260904-abreibung-schnupfen-texten-3120c46b6d23@brauner>

On Fri, 2026-09-04 at 12:50 +0200, Christian Brauner wrote:
> > The main problem is that an attribute delegation has strict rules about
> > updates can be done, and that prevents applications that backdate
> > timestamps on files after writing them, (e.g. tar -x, cp -p, etc.) from
> > setting them properly.
> > 
> > We could fix this on the client by making it always issue an RPC for the
> > SETATTR, but that would harm performance in these common use-cases.
> > This set allows the server to accept some of these backdated mtime
> > updates, by changing how the ctime is handled.
> > 
> > It'd be nice to see this in v7.4.
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> 
> There's a bunch of Sashiko comments outstanding, Jeff. Let me know, if I
> can ignore them.


At least one of them looks valid. I'll plan to send a v3.

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>

      reply	other threads:[~2026-09-04 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 18:54 [PATCH v2 0/3] fs/nfsd: accept a backdated timestamp from a delegation holder Jeff Layton
2026-09-02 18:54 ` [PATCH v2 1/3] fs: stamp the current time for a stale delegated ctime update Jeff Layton
2026-09-03  9:37   ` Jan Kara
2026-09-02 18:54 ` [PATCH v2 2/3] nfsd: accept a backdated timestamp from a delegation holder Jeff Layton
2026-09-02 18:54 ` [PATCH v2 3/3] nfsd: compare CB_GETATTR times against the inode Jeff Layton
2026-09-03  0:03 ` [PATCH v2 0/3] fs/nfsd: accept a backdated timestamp from a delegation holder Chuck Lever
2026-09-04 10:30   ` Christian Brauner
2026-09-04 10:50 ` Christian Brauner
2026-09-04 11:10   ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932876f491f436d622f3c365cfe6fda1225833c5.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=brauner@kernel.org \
    --cc=cel@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=loghyr@gmail.com \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox