From: Chuck Lever <chuck.lever@oracle.com>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Bruce Fields <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd/nfs3: remove unused macro nfsd3_fhandleres
Date: Fri, 6 Nov 2020 09:29:11 -0500 [thread overview]
Message-ID: <94040377-C2A4-47DF-BBA1-16573F69739D@oracle.com> (raw)
In-Reply-To: <1604641257-6159-1-git-send-email-alex.shi@linux.alibaba.com>
> On Nov 6, 2020, at 12:40 AM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
> The macro is unused, remove it to tame gcc warning:
> fs/nfsd/nfs3proc.c:702:0: warning: macro "nfsd3_fhandleres" is not used
> [-Wunused-macros]
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Cc: linux-nfs@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/nfsd/nfs3proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
> index 781e265921aa..6e79bae0af4d 100644
> --- a/fs/nfsd/nfs3proc.c
> +++ b/fs/nfsd/nfs3proc.c
> @@ -687,7 +687,6 @@
> #define nfsd3_mkdirargs nfsd3_createargs
> #define nfsd3_readdirplusargs nfsd3_readdirargs
> #define nfsd3_fhandleargs nfsd_fhandle
> -#define nfsd3_fhandleres nfsd3_attrstat
> #define nfsd3_attrstatres nfsd3_attrstat
> #define nfsd3_wccstatres nfsd3_attrstat
> #define nfsd3_createres nfsd3_diropres
> --
> 1.8.3.1
Applied to cel-next, thanks Alex.
The topic branch that collects patches for nfsd-5.11 is here:
http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=shortlog;h=refs/heads/cel-next
--
Chuck Lever
prev parent reply other threads:[~2020-11-06 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 5:40 [PATCH] nfsd/nfs3: remove unused macro nfsd3_fhandleres Alex Shi
2020-11-06 14:29 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94040377-C2A4-47DF-BBA1-16573F69739D@oracle.com \
--to=chuck.lever@oracle.com \
--cc=alex.shi@linux.alibaba.com \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox