Re: [PATCH 0/6 v2] nfs_localio: fixes for races and errors from older compilers

Mike Snitzer
2025-05-09T21:02:30Z

On Fri, May 09, 2025 at 12:01:19PM -0400, Chuck Lever wrote:
> [ adding Paul McK ]
>
> On 5/8/25 8:46 PM, NeilBrown wrote:
> > This is a revised version a the earlier series. I've actually tested
> > this time and fixed a few issues including the one that Mike found.
>
> As Mike mentioned in a previous thread, at this point, any fix for this
> issue will need to be applied to recent stable kernels as well. This
> series looks a bit too complicated for that.
>
> I expect that other subsystems will encounter this issue eventually,
> so it would be beneficial to address the root cause. For that purpose, I
> think I like Vincent's proposal the best:
>
> https://lore.kernel.org/linux-nfs/8c67a295-8caa-4e53-a764-f691657bbe62@wanadoo.fr/raw
>
> None of this is to say that Neil's patches shouldn't be applied. But
> perhaps these are not a broad solution to the RCU compilation issue.

I agree with your suggested approach. Hopefully Paul agrees and
Vincent can polish a patch for near-term inclusion.

It'll be at least a week before I can put adequate time to reviewing
and testing Neil's patchset.

Thanks,
Mike