From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc: kernel test robot <oliver.sang@intel.com>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] NFSD: Fix a thinko introduced by recent trace point changes
Date: Thu, 24 Aug 2023 15:42:03 -0400 [thread overview]
Message-ID: <9867b999cbd8cab2a7cdc809d75579bd9528c953.camel@kernel.org> (raw)
In-Reply-To: <169288742767.62637.4868507858344398487.stgit@klimt.1015granger.net>
On Thu, 2023-08-24 at 10:30 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> The fixed commit erroneously removed a call to nfsd_end_grace(),
> which makes calls to write_v4_end_grace() a no-op.
>
> Fixes: 39d432fc7630 ("NFSD: trace nfsctl operations")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202308241229.68396422-oliver.sang@intel.com
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfsctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 1b8b1aab9a15..4302ca0ff6ed 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1105,6 +1105,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size)
> if (!nn->nfsd_serv)
> return -EBUSY;
> trace_nfsd_end_grace(netns(file));
> + nfsd4_end_grace(nn);
> break;
> default:
> return -EINVAL;
>
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-08-24 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 14:30 [PATCH] NFSD: Fix a thinko introduced by recent trace point changes Chuck Lever
2023-08-24 19:42 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9867b999cbd8cab2a7cdc809d75579bd9528c953.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).