* [PATCH] NFSD: Fix a thinko introduced by recent trace point changes
@ 2023-08-24 14:30 Chuck Lever
2023-08-24 19:42 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2023-08-24 14:30 UTC (permalink / raw)
To: linux-nfs; +Cc: kernel test robot, Chuck Lever
From: Chuck Lever <chuck.lever@oracle.com>
The fixed commit erroneously removed a call to nfsd_end_grace(),
which makes calls to write_v4_end_grace() a no-op.
Fixes: 39d432fc7630 ("NFSD: trace nfsctl operations")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202308241229.68396422-oliver.sang@intel.com
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfsctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 1b8b1aab9a15..4302ca0ff6ed 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -1105,6 +1105,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size)
if (!nn->nfsd_serv)
return -EBUSY;
trace_nfsd_end_grace(netns(file));
+ nfsd4_end_grace(nn);
break;
default:
return -EINVAL;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] NFSD: Fix a thinko introduced by recent trace point changes
2023-08-24 14:30 [PATCH] NFSD: Fix a thinko introduced by recent trace point changes Chuck Lever
@ 2023-08-24 19:42 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2023-08-24 19:42 UTC (permalink / raw)
To: Chuck Lever, linux-nfs; +Cc: kernel test robot, Chuck Lever
On Thu, 2023-08-24 at 10:30 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> The fixed commit erroneously removed a call to nfsd_end_grace(),
> which makes calls to write_v4_end_grace() a no-op.
>
> Fixes: 39d432fc7630 ("NFSD: trace nfsctl operations")
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202308241229.68396422-oliver.sang@intel.com
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfsctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 1b8b1aab9a15..4302ca0ff6ed 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1105,6 +1105,7 @@ static ssize_t write_v4_end_grace(struct file *file, char *buf, size_t size)
> if (!nn->nfsd_serv)
> return -EBUSY;
> trace_nfsd_end_grace(netns(file));
> + nfsd4_end_grace(nn);
> break;
> default:
> return -EINVAL;
>
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-24 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 14:30 [PATCH] NFSD: Fix a thinko introduced by recent trace point changes Chuck Lever
2023-08-24 19:42 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).