From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 08/10] locks: Set FL_CLOSE when removing flock locks on close()
Date: Mon, 28 Dec 2015 11:28:04 -0500 [thread overview]
Message-ID: <999b2265fc3122b43f4da46b577f53f5555db2ab.1451319354.git.bcodding@redhat.com> (raw)
In-Reply-To: <cover.1451319354.git.bcodding@redhat.com>
In-Reply-To: <cover.1451319354.git.bcodding@redhat.com>
Use FL_CLOSE in fl_flags as in locks_remove_posix() when clearing locks.
NFS will depend on this flag to properly defer an unlock until IO under the
current lock has completed.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
fs/locks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 0d2b326..9aea07a 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2423,7 +2423,7 @@ locks_remove_flock(struct file *filp, struct file_lock_context *flctx)
.fl_owner = filp,
.fl_pid = current->tgid,
.fl_file = filp,
- .fl_flags = FL_FLOCK,
+ .fl_flags = FL_FLOCK | FL_CLOSE,
.fl_type = F_UNLCK,
.fl_end = OFFSET_MAX,
};
--
1.7.1
next prev parent reply other threads:[~2015-12-28 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 16:27 [PATCH v3 00/10] locking fixups for NFS Benjamin Coddington
2015-12-28 16:27 ` [PATCH v3 01/10] NFS4: remove a redundant lock range check Benjamin Coddington
2015-12-28 19:35 ` Jeff Layton
2015-12-28 16:27 ` [PATCH v3 02/10] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2015-12-28 19:37 ` Jeff Layton
2015-12-29 13:34 ` Benjamin Coddington
2015-12-28 16:27 ` [PATCH v3 03/10] NFS: Pass nfs_open_context instead of file to the lock procs Benjamin Coddington
2015-12-28 19:44 ` Jeff Layton
2015-12-29 13:24 ` Benjamin Coddington
2015-12-29 13:34 ` Jeff Layton
2015-12-28 16:28 ` [PATCH v3 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck() Benjamin Coddington
2015-12-29 13:37 ` Jeff Layton
2015-12-28 16:28 ` [PATCH v3 05/10] lockd: Plumb nfs_open_context into nlm client unlock Benjamin Coddington
2015-12-29 13:43 ` Jeff Layton
2015-12-29 14:08 ` Benjamin Coddington
2015-12-29 14:55 ` Jeff Layton
2015-12-28 16:28 ` [PATCH v3 06/10] lockd: Send the inode to nlmclnt_setlockargs() Benjamin Coddington
2015-12-28 16:28 ` [PATCH v3 07/10] lockd: do_vfs_lock() only needs the inode Benjamin Coddington
2015-12-28 16:28 ` Benjamin Coddington [this message]
2015-12-28 16:28 ` [PATCH v3 09/10] NFS: Deferred unlocks - always unlock on FL_CLOSE Benjamin Coddington
2015-12-28 16:28 ` [PATCH v3 10/10] NFS: cleanup do_vfs_lock() Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999b2265fc3122b43f4da46b577f53f5555db2ab.1451319354.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).