From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D1E33E7; Fri, 23 Jan 2026 16:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769186892; cv=none; b=utnX3xEyCm5C2Yl/2bh4+ntfwUZNtSy4eoor5F8JsQpbn29ve460QONLWV4f1BuP7Ax3LPZh45T95f9WZcjcBfoZq8LL0UDz68RReoMZ5SnSI+6WZPk8xohYsycT3tY0Ek47aU78BgI5UCMaGsxA3Cmkttg0kOdYH7LwshtFgTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769186892; c=relaxed/simple; bh=8fZ4K5WLfftCoZyKTJXsvCrQFOZMYmEclJhgysmxvK8=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=eqan30yMMWk9p8VnkaAEqvHBiHkmomY+RmYbr3ahiq+9TJ8eBYl4Jq7Ny4IjPi81tWFI51NdXgbtTl/0YvipkXWbmMETLHZDuS+0TDYGeYWXyVl83pXv8t3o0KWGpvjbsoO6r9iD5l+qDH8omM3HtpTF9Z9/7H7omAR963+qipg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R9L/e1eC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R9L/e1eC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F55EC4AF09; Fri, 23 Jan 2026 16:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769186891; bh=8fZ4K5WLfftCoZyKTJXsvCrQFOZMYmEclJhgysmxvK8=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=R9L/e1eCmcw7V0jtkyLPANgjssYuQLBLWtjl4Ot9PGECwVDM0NIEh1vZA0PHdbcOF Qol2yug1yTF5JBsj/dR66ZfnS3q4ktE2FVA9mDc6wOQggT2/GebdGtBhk5r63Hecuh gHWMdyOYl+MoLZ2nXm1zxlxH3vy/kZLLDZ6TJnTq/8xbBj6wkqPGl8DWGaUZSEqChC zu2Gbd2C3iXGctQ0NfR524rZQWA76nS0KYKXJLUt52cFIWL54r91sCEJRyZABfR0m1 JJfMFZ9qDlBsEOOsLz4FLiwk9pue+NqAIp+/l3JCVycM7z24o5nqjGbx5lggF5NOru cTI5CIXHwXwvg== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 86E75F4006A; Fri, 23 Jan 2026 11:48:10 -0500 (EST) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Fri, 23 Jan 2026 11:48:10 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugeelheeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfvehhuhgt khcunfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrh hnpefhffekffeftdfgheeiveekudeuhfdvjedvfedvueduvdegleekgeetgfduhfefleen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhhutg hklhgvvhgvrhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeifeegleel leehledqfedvleekgeegvdefqdgtvghlpeepkhgvrhhnvghlrdhorhhgsehfrghsthhmrg hilhdrtghomhdpnhgspghrtghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgt phhtthhopehjlhgrhihtohhnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlvghonh eskhgvrhhnvghlrdhorhhgpdhrtghpthhtohephhgthheslhhsthdruggvpdhrtghpthht ohepjhhgghesnhhvihguihgrrdgtohhmpdhrtghpthhtoheptghhuhgtkhdrlhgvvhgvrh esohhrrggtlhgvrdgtohhmpdhrtghpthhtohepuggrihdrnhhgohesohhrrggtlhgvrdgt ohhmpdhrtghpthhtohepnhgvihhlsgesohifnhhmrghilhdrnhgvthdprhgtphhtthhope hokhhorhhnihgvvhesrhgvughhrghtrdgtohhmpdhrtghpthhtohepthhomhesthgrlhhp vgihrdgtohhm X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 6489B780070; Fri, 23 Jan 2026 11:48:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: Ayo69OWiNnSN Date: Fri, 23 Jan 2026 11:47:46 -0500 From: "Chuck Lever" To: "Christoph Hellwig" Cc: "Jason Gunthorpe" , "Leon Romanovsky" , NeilBrown , "Jeff Layton" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org, "Chuck Lever" Message-Id: <9a8a0671-29a2-4220-8d38-361a6718b7ea@app.fastmail.com> In-Reply-To: <20260123063622.GA26025@lst.de> References: <20260122220401.1143331-1-cel@kernel.org> <20260122220401.1143331-4-cel@kernel.org> <20260123063622.GA26025@lst.de> Subject: Re: [PATCH v3 3/5] RDMA/core: add MR support for bvec-based RDMA operations Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Jan 23, 2026, at 1:36 AM, Christoph Hellwig wrote: >> for (i = 0; i < ctx->nr_ops; i++) { >> - struct rdma_rw_reg_ctx *reg = &ctx->reg[i]; >> + struct rdma_rw_reg_ctx *reg = &ctx->reg.ctx[i]; > > Jumping ahead here - why can't the sgtable be stored in ->reg > without renaming? Is there case where need it, but the rest of > reg? In I think the answer is yes, with bvec, both fields are needed at the same time. My preference is to go back to the early form of the structure without a union, since there are API consumers who access the reg field directly. Let me know your thoughts. -- Chuck Lever