From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C32C426B2CE; Wed, 18 Mar 2026 14:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773844349; cv=none; b=owsqlllp++9rvOBpd1yoPmoDk83x3AZeIPjRooK8ksQGOuaIh4gHdhjlLSPEgSjrAsnnKjSdzndFG/H0N3F3L8RIA61u1jaYN6TSHolMJxwA44rdgpuqJo+8+P0ae6k6V7aKABhqTQ/6RjozCRvurIvfILLYNUoKWwjn14OUhNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773844349; c=relaxed/simple; bh=BFLH9MG6O8BjoyXkSjBPGPGjZPG0kogd7pgludm/72o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LmB5q83/Nu17DqvHEtEM33fnFZ5wqKp5t1PuEyR4aF2HyXv70jvW2zCcagqUAfQts+xdgXDW0J2G8n57CMHHHMLPhXXnoNiwKIz3Zxs+vqI2ZRyk8WwoGnwtLbvS+Gfc+nH+0uyWQVYZS60p1Kui5at1RhNNSmkOsVkGEgKfr70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=un1V4RYn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="un1V4RYn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE9EAC19421; Wed, 18 Mar 2026 14:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773844349; bh=BFLH9MG6O8BjoyXkSjBPGPGjZPG0kogd7pgludm/72o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=un1V4RYnKiJ5Y6ZmOKrrGfcK9MjgK6PBQcCshnV8j8RCPkkkjjFTUFhcpKqYRSDfS p2t164W2L9twF03tg3vAy1F4h4Wo/GYlFYDvVMTmdat+HjDkxxCdJRy2oGoprC7b7T CjesFUt76JfCgJDJu1xaA6fzJr9RQ/n1o0T085jvhoak9ScSQhuxrk3go8s4xxavxq AjVVgX61yVhYiLnIYjqK2kF1PKCHExkR1Qem09Quwx7M2bWyZ0Cbr2Lqjauo/o/OLj n379hEcB+ESqSvOHFfmQ5nnGgderCvlVn6CL7d67vWfpdKFu4POTgkgBjXjOlYLlFn 67mv/VOvmeMQA== Message-ID: <9ea5b835-5e91-458c-9929-c1df7e6df25d@kernel.org> Date: Wed, 18 Mar 2026 10:32:27 -0400 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] NFSD: Add NFSD_CMD_UNLOCK netlink command with ip scope To: Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Chuck Lever References: <20260318-umount-kills-nfsv4-state-v4-0-56aad44ab982@oracle.com> <20260318-umount-kills-nfsv4-state-v4-2-56aad44ab982@oracle.com> <33d42b3de7a2c7cd61bdd01bae04a2e082755f95.camel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: <33d42b3de7a2c7cd61bdd01bae04a2e082755f95.camel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/18/26 10:28 AM, Jeff Layton wrote: > On Wed, 2026-03-18 at 10:15 -0400, Chuck Lever wrote: >> From: Chuck Lever >> @@ -227,3 +249,13 @@ operations: >> attributes: >> - mode >> - npools >> + - >> + name: unlock >> + doc: release NLM locks by scope >> + attribute-set: unlock >> + flags: [admin-perm] >> + do: >> + request: >> + attributes: >> + - type >> + - address > > I wonder if we'd be better served with different commands instead of > passing a type value to a single command? Different types are going to > require different attributes, and it'll be easier to validate those if > they use different commands. I was following your philosophy about the THREADS command. But it's correct that the YAML/netlink infrastructure struggles a bit when the arguments for each of the subcommands are so different from each other. I don't think it would be difficult to break UNLOCK into three separate unlock netlink commands. -- Chuck Lever