From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A76031B111 for ; Wed, 10 Dec 2025 13:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765375015; cv=none; b=BNXsQEvrNaXshTd8W4OgJrY0Fr+dfde7SyBZY3zXLpahYm1LTRHNf24MTb5EOPShIgF7k5t2SK/lRtHdIbWO4MQmZia1SSHTNIdBAfEJE0MkQki65qWzT6kQ1XZlqbw9nm5guWQEmHubxJCG/Y/DSvyzILDhSZL32JEHwPmu12s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765375015; c=relaxed/simple; bh=ou9T/NoEP9eDmLZQVCdbq0JkKzCU0vxJBsaaqvCiVss=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=P8Rnxk/6JZz25asDEA/zit6Ivl1taXjN3I32J3kO+Yf6MdKEW+KiUKYwJJicumyEUSEHiuYc9vuW6pYTGxBuZV8e1pgbN58wgaMG2KlLl6JxGXqF8zHgnK2KjcazaWEnic2KVojmISB4L5bIvcFrwYXwnnxtasqWA5xqhW3fXcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qdoqgGvw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qdoqgGvw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59458C4CEF1; Wed, 10 Dec 2025 13:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765375014; bh=ou9T/NoEP9eDmLZQVCdbq0JkKzCU0vxJBsaaqvCiVss=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=qdoqgGvwpqw4BO0frns1J3iowajzAoaH6jShe42Owcz+Qit7mGapoPUMFw4mPEpBG VSEzhg58J6kep/63xqqToMCA5jlWWLSkPunNApf0mdndqpQf/hOgo0oMmz85sNyNWV wJu2l93aPQM8z7Vuzx3UmA2TZK3PeBU64xidrUcbF/ikUKw6t6EeEiHvlhb1STvKYz H4lRrdCesQZTXoks+EwMjeIAVoUftMo+/QcFNxqRcxA8rFCAiwdKkmUWpWs9EHDLq0 2Vr0Z0A4uXKJyeETjmwNizi4uu06W3MvuRF4jkPcCQ8M4UIYQldrGioPQcFzFjnsyQ OQrNYuoB4ihkQ== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 84799F40068; Wed, 10 Dec 2025 08:56:53 -0500 (EST) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Wed, 10 Dec 2025 08:56:53 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvvdeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdevhhhutghk ucfnvghvvghrfdcuoegtvghlsehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvghrnh ephfffkefffedtgfehieevkeduuefhvdejvdefvdeuuddvgeelkeegtefgudfhfeelnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghhuhgtkh hlvghvvghrodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieefgeelleel heelqdefvdelkeeggedvfedqtggvlheppehkvghrnhgvlhdrohhrghesfhgrshhtmhgrih hlrdgtohhmpdhnsggprhgtphhtthhopedujedpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepnhgvihhlsegsrhhofihnrdhnrghmvgdprhgtphhtthhopegurghvvghmsegurg hvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdr tghomhdprhgtphhtthhopegrnhhnrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohephh horhhmsheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhhlrgihthhonheskhgvrhhn vghlrdhorhhgpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtth hopehtrhhonhgumhihsehkvghrnhgvlhdrohhrghdprhgtphhtthhopeiihhgrohgthhgv nhhguhgrnhhgsehkhihlihhnohhsrdgtnh X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 561F7780054; Wed, 10 Dec 2025 08:56:53 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AhUqZCzku-iw Date: Wed, 10 Dec 2025 08:56:33 -0500 From: "Chuck Lever" To: "Chenguang Zhao" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <9fd4fded-abee-45ab-8654-359f98846ba2@app.fastmail.com> In-Reply-To: <20251208085348.467419-1-zhaochenguang@kylinos.cn> References: <20251208085348.467419-1-zhaochenguang@kylinos.cn> Subject: Re: [PATCH linux-next v2] SUNRPC: Change list definition method Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Dec 8, 2025, at 3:53 AM, Chenguang Zhao wrote: > The LIST_HEAD macro can both define a linked list and initialize > it in one step. To simplify code, we replace the separate operations > of linked list definition and manual initialization with the LIST_HEAD > macro. > > Signed-off-by: Chenguang Zhao > --- > v2: > - Modify the commit message according to Chuck's suggestion > > net/sunrpc/backchannel_rqst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sunrpc/backchannel_rqst.c b/net/sunrpc/backchannel_rqst.c > index caa94cf57123..949022c5574c 100644 > --- a/net/sunrpc/backchannel_rqst.c > +++ b/net/sunrpc/backchannel_rqst.c > @@ -131,7 +131,7 @@ EXPORT_SYMBOL_GPL(xprt_setup_backchannel); > int xprt_setup_bc(struct rpc_xprt *xprt, unsigned int min_reqs) > { > struct rpc_rqst *req; > - struct list_head tmp_list; > + LIST_HEAD(tmp_list); > int i; > > dprintk("RPC: setup backchannel transport\n"); > @@ -147,7 +147,6 @@ int xprt_setup_bc(struct rpc_xprt *xprt, unsigned > int min_reqs) > * lock is held on the rpc_xprt struct. It also makes cleanup > * easier in case of memory allocation errors. > */ > - INIT_LIST_HEAD(&tmp_list); > for (i = 0; i < min_reqs; i++) { > /* Pre-allocate one backchannel rpc_rqst */ > req = xprt_alloc_bc_req(xprt); > -- > 2.25.1 backchannel_rqst.c looks like a client-side file, so I defer to my colleagues who maintain the Linux NFS client. Reviewed-by: Chuck Lever -- Chuck Lever