Re: pnfs git tree status pnfs-all-2.6.36-rc6-2010-09-29

[Fred Isaman <iisaman@netapp.com>]

Tigran, are you sure you are running with Benny's suggested patch?
The two oopses you posted from before and after look suspiciously
similar.

Fred

On Wed, Sep 29, 2010 at 12:57 PM, Tigran Mkrtchyan
<tigran.mkrtchyan@desy.de> wrote:
>
>> Tigran, do you have a new trace maybe?
>> I cross referenced the dump you sent to the
>> disassembled code and it seems like it hit NULL dereference on
>> size = fl->stripe_unit;
>>
>> I'm going to commit this patch anyway but I want to
>> understand what else I missed...
>>
>> Benny
>>
>
> The stack attached.  Shall I compile the kernel with some debug options for
> better debugging?
>
> Tigran.
>>>>
>>>> git diff --stat -p -M
>>>>   fs/nfs/nfs4filelayout.c |    2 ++
>>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
>>>> index 75e07c8..8fbb0db 100644
>>>> --- a/fs/nfs/nfs4filelayout.c
>>>> +++ b/fs/nfs/nfs4filelayout.c
>>>> @@ -636,6 +636,8 @@ filelayout_get_stripesize(struct pnfs_layout_hdr
>>>> *lo)
>>>>
>>>>        /* Horrible hack...ideally upper layer would send lseg */
>>>>        lseg = pnfs_has_layout(lo,&range);
>>>> +       if (!lseg)
>>>> +               return 0;
>>>>        fl = container_of(lseg, struct nfs4_filelayout_segment,
>>>> generic_hdr);
>>>>        size = fl->stripe_unit;
>>>>        put_lseg_locked(lseg);
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>