From: Fred Isaman <iisaman@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org, Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH 04/14] pnfs: wave 2: change layout state seqlock to a spinlock
Date: Tue, 21 Dec 2010 10:47:13 -0500 [thread overview]
Message-ID: <AANLkTimHtMsKB1Z-LQnGebJxuOk8AMVpuANshDKG5V0D@mail.gmail.com> (raw)
In-Reply-To: <20101221152639.GC30248@infradead.org>
On Tue, Dec 21, 2010 at 10:26 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Dec 20, 2010 at 09:20:36PM -0500, Fred Isaman wrote:
>> This prepares for future changes, where the layout state needs
>> to change atomically with several other variables. In particular,
>> it will need to know if lo->segs is empty, as we test that instead
>> of manipulating the NFS_LAYOUT_STATEID_SET bit. Moreover, the
>> layoutstateid is not really a read-mostly structure, as it is
>> written almost as often as it is read.
>
> It also renames a couple of functions.
>
I assume you refer to pnfs_get_layout_stateid ->
pnfs_choose_layoutget_stateid. I was thinking of them as entirely
different functions, as one actually changed the stateid, and the
other doesn't. But I can put a comment in the description clarifying
that.
Fred
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-12-21 15:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 2:20 [PATCH 00/14] pnfs wave 2 submission Fred Isaman
2010-12-21 2:20 ` [PATCH 01/14] pnfs: wave 2: fix incorrect comment in destroy_lseg Fred Isaman
2010-12-21 2:20 ` [PATCH 02/14] pnfs: wave 2: remove unnecessary field lgp->status Fred Isaman
2010-12-21 2:20 ` [PATCH 03/14] pnfs: wave 2: rename lo->state to lo->plh_flags Fred Isaman
2010-12-21 15:21 ` Christoph Hellwig
2010-12-21 15:42 ` Fred Isaman
2010-12-21 2:20 ` [PATCH 04/14] pnfs: wave 2: change layout state seqlock to a spinlock Fred Isaman
2010-12-21 15:26 ` Christoph Hellwig
2010-12-21 15:47 ` Fred Isaman [this message]
2010-12-21 2:20 ` [PATCH 05/14] pnfs: wave 2: change how lsegs are removed from layout list Fred Isaman
2010-12-21 2:20 ` [PATCH 06/14] pnfs: wave 2: layoutget rpc code cleanup Fred Isaman
2010-12-21 2:20 ` [PATCH 07/14] pnfs: wave 2: serialize LAYOUTGET(openstateid) Fred Isaman
2010-12-21 2:20 ` [PATCH 08/14] pnfs: wave 2: Add layout to client list before sending rpc Fred Isaman
2010-12-21 2:20 ` [PATCH 09/14] pnfs: wave 2: check that partial LAYOUTGET return is ignored Fred Isaman
2010-12-21 2:20 ` [PATCH 10/14] pnfs: wave 2: change lo refcounting to atomic_t Fred Isaman
2010-12-21 2:20 ` [PATCH 11/14] pnfs: wave 2: CB_LAYOUTRECALL xdr code Fred Isaman
2010-12-21 2:20 ` [PATCH 12/14] pnfs: wave 2: add CB_LAYOUTRECALL handling Fred Isaman
2010-12-21 2:20 ` [PATCH 13/14] pnfs: wave 2: update nfs4_callback_recallany to handle layouts Fred Isaman
2010-12-21 2:20 ` [PATCH 14/14] pnfs: wave 2: layout roc code Fred Isaman
2010-12-21 15:20 ` [PATCH 00/14] pnfs wave 2 submission Christoph Hellwig
2010-12-21 15:38 ` Benny Halevy
2010-12-21 15:40 ` Fred Isaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimHtMsKB1Z-LQnGebJxuOk8AMVpuANshDKG5V0D@mail.gmail.com \
--to=iisaman@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).