From: Fred Isaman <iisaman@netapp.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>,
NFS list <linux-nfs@vger.kernel.org>,
Andy Adamson <andros@netapp.com>
Subject: Re: [PATCH] SQUASHME: pnfs: FIX stupid recall_layout BUG
Date: Sun, 27 Feb 2011 14:09:02 -0800 [thread overview]
Message-ID: <AANLkTimZS=54ZkwXwK9tMUUBn_JDXD5=+ohBpnKemtbQ@mail.gmail.com> (raw)
In-Reply-To: <4D6A67F3.3060308@panasas.com>
On Sun, Feb 27, 2011 at 7:04 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> OK, who wrote this code? He did not stop to think for even a
> second. And surely it was never tested, since it is 100%
> repeatable. Smack yourself on the head!
>
I wrote the code. But note that the tree you are using is taking the
tested, reasonably mature code that is currently in the downstream
kernel and reverting it back to ancient buggy prototype code. My
understanding was that Benny was rightly ripping out the reversions at
bakeathon.
Fred
next prev parent reply other threads:[~2011-02-27 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:42 Client still crashing on 2nd callback after NFS4_ERR_DELAY Boaz Harrosh
2011-02-27 15:04 ` [PATCH] SQUASHME: pnfs: FIX stupid recall_layout BUG Boaz Harrosh
2011-02-27 22:09 ` Fred Isaman [this message]
2011-02-28 18:24 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimZS=54ZkwXwK9tMUUBn_JDXD5=+ohBpnKemtbQ@mail.gmail.com' \
--to=iisaman@netapp.com \
--cc=andros@netapp.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).