linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Patrick J. LoPresti" <lopresti@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Proposal: Use hi-res clock for file timestamps
Date: Wed, 18 Aug 2010 11:32:20 -0700	[thread overview]
Message-ID: <AANLkTin2EOzA5grh5qjZghAs0Y4DbcGBhmdfqp=u1S_4@mail.gmail.com> (raw)
In-Reply-To: <1282155658.13405.36.camel@localhost>

On Wed, Aug 18, 2010 at 11:20 AM, David Woodhouse <dwmw2@infradead.org> wrote:
>
> Um, can't you? You can't *store* timestamps which are more precise, but
> they can be in cache can't they?

No.  That is how Linux used to work, and it caused many problems,
which is why the current_fs_time() function was invented.

> And since you're not going to drop it from cache and bring it back in
> again within 4ms, that ought to suffice?

Not the problem.  As usual, the problem is out-of-order timestamps:

1) Modify file A
2) Modify file B
3) File B's inode gets evicted, truncating its timestamp to disk resolution
4) Call stat() on B, bringing it back in with truncated resolution

And boom, B appears to be OLDER than A.  Which is not allowed.

This is exactly what happened when Linux first added sub-second
timestamps to the generic VFS layer.  Many complaints about "make"
rebuilding files unecessarily, among other things.  Eventually it got
fixed by the introduction of current_fs_time().

 - Pat

  reply	other threads:[~2010-08-18 18:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 18:25 Proposal: Use hi-res clock for file timestamps Patrick J. LoPresti
2010-08-13 18:45 ` john stultz
2010-08-13 18:57   ` Patrick J. LoPresti
2010-08-13 19:09     ` john stultz
2010-08-13 20:53       ` Patrick J. LoPresti
2010-08-14 16:45         ` Patrick J. LoPresti
2010-08-15  1:50         ` Bret Towe
2010-08-13 19:57     ` Jim Rees
2010-08-13 20:26       ` john stultz
2010-08-13 20:52         ` Jim Rees
2010-08-17 14:54 ` Andi Kleen
2010-08-17 17:41   ` J. Bruce Fields
2010-08-17 18:29     ` Andi Kleen
2010-08-17 18:50       ` Patrick J. LoPresti
2010-08-17 19:04       ` J. Bruce Fields
2010-08-17 19:18         ` Patrick J. LoPresti
2010-08-17 19:39           ` Alan Cox
2010-08-17 19:29             ` J. Bruce Fields
2010-08-17 19:52               ` Alan Cox
2010-08-18  5:53               ` Neil Brown
2010-08-18 14:46                 ` Patrick J. LoPresti
2010-08-18 17:32                 ` J. Bruce Fields
2010-08-18 18:15                   ` Chuck Lever
2010-08-18 23:41                     ` Neil Brown
2010-08-19  0:52                       ` Neil Brown
2010-08-19  2:08                         ` J. Bruce Fields
2010-08-19  2:44                           ` Neil Brown
2010-08-19 22:46                             ` J. Bruce Fields
2010-08-18 23:47                   ` Neil Brown
2010-08-18 17:50                 ` Andi Kleen
2010-08-18 18:54                   ` J. Bruce Fields
2010-08-18 19:25                     ` Andi Kleen
2010-08-18 19:30                       ` J. Bruce Fields
2010-08-17 19:34             ` Patrick J. LoPresti
2010-08-17 19:54               ` Alan Cox
2010-08-17 19:43                 ` Patrick J. LoPresti
2010-08-17 19:45                   ` J. Bruce Fields
2010-08-18 18:12               ` J. Bruce Fields
2010-08-19  1:41                 ` john stultz
2010-08-19  2:31                   ` J. Bruce Fields
2010-08-19  3:17                     ` john stultz
2010-08-19 22:53                       ` J. Bruce Fields
2010-08-18 18:20       ` David Woodhouse
2010-08-18 18:32         ` Patrick J. LoPresti [this message]
2010-08-18 18:53         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTin2EOzA5grh5qjZghAs0Y4DbcGBhmdfqp=u1S_4@mail.gmail.com' \
    --to=lopresti@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=bfields@fieldses.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).