From: Chuck Lever <chuck.lever@oracle.com>
To: Mi Jinlong <mijinlong@cn.fujitsu.com>
Cc: Steve Dickson <SteveD@redhat.com>, NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] svc: make sure mountd can get ports from /etc/services
Date: Wed, 20 Apr 2011 11:08:23 -0400 [thread overview]
Message-ID: <AD03EC99-CB5C-41BA-AE0B-FEA7A8D48B6E@oracle.com> (raw)
In-Reply-To: <4DAEA782.2090108@cn.fujitsu.com>
On Apr 20, 2011, at 5:29 AM, Mi Jinlong wrote:
>
>
> Chuck Lever:
>> Hi MJ-
>>
>> On Apr 19, 2011, at 4:33 AM, Mi Jinlong wrote:
>>
>>> At RHEL, if user set port for mountd at /etc/services as
>>> "mount 12345/tcp", mountd should be bind to 12345, but the
>>> latest nfs-utils, mountd get a rand port, not 12345.
>>>
>>> This patch make sure mountd be bind to the port which was set
>>> at /etc/service.
>>
>> I don't think this is documented anywhere. Is there a reason it should work this way?
>>
>> The typical way to set mountd's port is to use a command line option. That's the way it works for all the other RPC daemons. By default the ports are set up at random and registered with rpcbind. That's why clients use rpcbind, and not /etc/services, to find these services.
>
> I don't have a depth research, agree with you.
> But I got different result when I set port for mountd at /etc/services
> between nfs-utils-1.2.3 and nfs-utils-1.2.2.
IMO that's unintentional behavior. Could I ask a favor: would you bisect nfs-utils to find out exactly where this started and ended?
> I just think we should get the same result at new nfs-utils as older.
Is there a real-world use case for this feature? Why isn't the command line option adequate?
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
next prev parent reply other threads:[~2011-04-20 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 8:33 [PATCH] svc: make sure mountd can get ports from /etc/services Mi Jinlong
2011-04-19 13:28 ` Chuck Lever
2011-04-20 9:29 ` Mi Jinlong
2011-04-20 15:08 ` Chuck Lever [this message]
2011-04-21 3:42 ` Mi Jinlong
2011-04-21 14:11 ` Chuck Lever
2011-04-25 7:09 ` Mi Jinlong
2011-04-25 15:58 ` Chuck Lever
2011-05-28 9:42 ` [PATCH v2] rpc.mountd: let mountd consult /etc/services for port Mi Jinlong
2011-05-28 13:29 ` Jim Rees
2011-05-28 16:01 ` Chuck Lever
2011-05-28 16:45 ` Jim Rees
2011-06-07 20:17 ` Steve Dickson
2011-06-10 8:23 ` Mi Jinlong
2011-08-03 17:52 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AD03EC99-CB5C-41BA-AE0B-FEA7A8D48B6E@oracle.com \
--to=chuck.lever@oracle.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=mijinlong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).