From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7D3C77B78 for ; Thu, 4 May 2023 12:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbjEDM5h (ORCPT ); Thu, 4 May 2023 08:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbjEDM5b (ORCPT ); Thu, 4 May 2023 08:57:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F3C559FD for ; Thu, 4 May 2023 05:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683205002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88eIQrGiFqCWFNvU+e8uQ+H0LUggzmKetsReRSSig9M=; b=dSulKI6LaXM/6JlZ74DMQfrIFhTT8x/3xurE5hTuYLO6JISPLgompR32cYrqqp1u4r+jrV x0FV0aaXosN/5ssQ2xqyS7vqqEkpwADgtfusCFhMSGbgAT2Z6OupvnQtX0rBNmckDvYJzC akCeXWnJcAyQC23H/ilYW+13Zaecp1E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-8uF3I8GHNbCKg46-MGPlug-1; Thu, 04 May 2023 08:56:39 -0400 X-MC-Unique: 8uF3I8GHNbCKg46-MGPlug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1BEB3C10C70; Thu, 4 May 2023 12:56:38 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.50.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B26E492C3E; Thu, 4 May 2023 12:56:38 +0000 (UTC) From: Benjamin Coddington To: Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: Re: [RFC PATCH] NFS: add a sysfs file for enabling & disabling nfs features Date: Thu, 04 May 2023 08:56:37 -0400 Message-ID: In-Reply-To: <20230421182738.901701-1-anna@kernel.org> References: <20230421182738.901701-1-anna@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 21 Apr 2023, at 14:27, Anna Schumaker wrote: > From: Anna Schumaker > > And add some basic checking so we only enable features that are present > in a given NFS version. > > Signed-off-by: Anna Schumaker > --- This is great, I like how you've kept the +/- notation similar to knfsd supported versions. Another way to do this would be an attribute file per capability, setting it to 0 or 1 which is more inline with sysfs usage. I think if we do use this, we ought to leave readdir plus out of it because there's already a mount option for it. Readdir plus can be turned on and off with a remount already. The issue for me would be how to work out what the behavior should be when we have a mount that has "nordirplus" and then someone tries to toggle it via sysfs. Any other thoughts? I'll add this patch to my future postings of sysfs work. Ben