From: Peng Huang <shawn.p.huang@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: check a crash in nfs_lookup_revalidate
Date: Fri, 13 May 2011 10:31:22 -0400 [thread overview]
Message-ID: <BANLkTikeCHBe3OBpuyF6jd_UeF0az0BYcg@mail.gmail.com> (raw)
In-Reply-To: <20110513103202.GA27578@infradead.org>
I did not write any code to call lookup_one_len(). I just mounted an
ecryptfs on nfs, and then got the oops. So it should be a problem in
nfs or ecryptfs or both. At least it should not crash.
Peng
On Fri, May 13, 2011 at 6:32 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, May 11, 2011 at 05:03:25PM -0400, Peng Huang wrote:
>> lookup_one_len() may call nfs_loopup_revalidate() with nd == NULL
>> indirectly, that causes the kernel crash.
>
> lookup_one_len must only be called by a filesystem or a library function
> called by the filesystem. You are not allowed to call it on a random
> filesystem like nfs that doesn't support the underlying assumptions.
>
>
prev parent reply other threads:[~2011-05-13 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 21:03 [PATCH] nfs: check a crash in nfs_lookup_revalidate Peng Huang
2011-05-11 21:08 ` Trond Myklebust
2011-05-11 21:35 ` Peng Huang
2011-05-11 22:08 ` Trond Myklebust
2011-05-11 22:17 ` Tyler Hicks
2011-05-11 22:33 ` Trond Myklebust
2011-05-11 23:07 ` Tyler Hicks
2011-05-13 10:32 ` Christoph Hellwig
2011-05-13 14:31 ` Peng Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikeCHBe3OBpuyF6jd_UeF0az0BYcg@mail.gmail.com \
--to=shawn.p.huang@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).